Solr
  1. Solr
  2. SOLR-4306

Utilize indexInfo=false when gathering core names in UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Implemented
    • Affects Version/s: 4.1
    • Fix Version/s: 4.2, Trunk
    • Component/s: web gui
    • Labels:
      None

      Description

      The capability added by SOLR-4302 could be used to speed up loading the UI, by not gathering full information from the core admin.

      1. SOLR-4306.patch
        0.9 kB
        Shawn Heisey
      2. SOLR-4306.patch
        1 kB
        Stefan Matheis (steffkes)

        Activity

        Hide
        Shawn Heisey added a comment -

        A patch that attempts to implement this change. It's entirely possible that I have overlooked something critical, or that I completely went about it the wrong way. Solr tests do pass with this patch on branch_4x.

        The little bit of poking around that I did in the UI on 4.2-SNAPSHOT did not turn up any noticeable problems. I just fired up the example. I will be able to try it on 4.1 with my multicore dev index tomorrow.

        If I did do it right, or the right way can be done quickly, it would be preferable to get this into the 4.1 release.

        Show
        Shawn Heisey added a comment - A patch that attempts to implement this change. It's entirely possible that I have overlooked something critical, or that I completely went about it the wrong way. Solr tests do pass with this patch on branch_4x. The little bit of poking around that I did in the UI on 4.2-SNAPSHOT did not turn up any noticeable problems. I just fired up the example. I will be able to try it on 4.1 with my multicore dev index tomorrow. If I did do it right, or the right way can be done quickly, it would be preferable to get this into the 4.1 release.
        Hide
        Markus Jelsma added a comment -

        +1

        Show
        Markus Jelsma added a comment - +1
        Hide
        Stefan Matheis (steffkes) added a comment -

        Another approach

        • The change in app.js should improve the initial loading of the UI
        • Therefore the cores_load_data callback can not longer rely on app.cores_data (the object may not contain the full set of information)
        • But we can rid of the indexInfo while submitting the form on the Core Admin (as long as no callback needs access to that information)
        Show
        Stefan Matheis (steffkes) added a comment - Another approach The change in app.js should improve the initial loading of the UI Therefore the cores_load_data callback can not longer rely on app.cores_data (the object may not contain the full set of information) But we can rid of the indexInfo while submitting the form on the Core Admin (as long as no callback needs access to that information)
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Stefan Matheis
        http://svn.apache.org/viewvc?view=revision&revision=1439518

        SOLR-4306: Utilize indexInfo=false when gathering core names in UI (merge r1439516)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1439518 SOLR-4306 : Utilize indexInfo=false when gathering core names in UI (merge r1439516)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Stefan Matheis
        http://svn.apache.org/viewvc?view=revision&revision=1439516

        SOLR-4306: Utilize indexInfo=false when gathering core names in UI

        Show
        Commit Tag Bot added a comment - [trunk commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1439516 SOLR-4306 : Utilize indexInfo=false when gathering core names in UI
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Stefan Matheis (steffkes)
            Reporter:
            Shawn Heisey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development