[SOLR-4288] Improve logging for FileDataSource (basePath, relative resources).

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1, 6.0
• Assignee: Dawid Weiss
• Reporter: Dawid Weiss
• Created: 09/Jan/13 14:12
• Updated: 09/May/16 18:55
• Resolved: 16/Jan/13 08:23

Description

In fact, the logic is broken:

      if (!file.isAbsolute())
        file = new File(basePath + query);

because basePath is null so 'null' is concatenated with the query string (path) resulting in an invalid path.

It should be checked if basePath is null, if so default to "."? Then resolve relative location as:

new File(basePathFile, query);

I'd also say change the log so that the absolute path is also logged in the warning message, otherwise it's really hard to figure out what's going on.