Solr
  1. Solr
  2. SOLR-4287

Maven artifact file names do not match dist/ file names

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: Build
    • Labels:
      None

      Description

      For the solr artifact, the war file name has the format "solr-X.Y.Z.war".
      http://search.maven.org/#artifactdetails%7Corg.apache.solr%7Csolr%7C4.0.0%7Cwar

      However, when building from source or downloading the dist/ built war file, it is named "apache-solr-X.Y.Z.war". This should really be the same...

      Preferably the "apache-" could just be removed, since the lucene build does not appear to use the same convention.

      1. SOLR-4287.patch
        14 kB
        Steve Rowe
      2. SOLR-4287_alternative.patch
        14 kB
        Robert Muir

        Activity

        Hide
        Steve Rowe added a comment -

        Patch removing "apache-" from all Ant-produced Solr artifact names.

        I haven't tested it yet, this is just the result of find/replace.

        Testing now.

        Show
        Steve Rowe added a comment - Patch removing "apache-" from all Ant-produced Solr artifact names. I haven't tested it yet, this is just the result of find/replace. Testing now.
        Hide
        Robert Muir added a comment -

        here's an alternative patch. Steve was doing it at the same time

        Show
        Robert Muir added a comment - here's an alternative patch. Steve was doing it at the same time
        Hide
        Steve Rowe added a comment -

        Robert, I applied your patch to a different trunk checkout and did a recursive diff on the two. There are no differences (other than .svn crap and IntelliJ config files).

        Show
        Steve Rowe added a comment - Robert, I applied your patch to a different trunk checkout and did a recursive diff on the two. There are no differences (other than .svn crap and IntelliJ config files).
        Hide
        Steve Rowe added a comment -

        FYI: we both made the same decision about removing "apache-" from the Solr release archive names (a separate issue from the artifact names).

        Show
        Steve Rowe added a comment - FYI: we both made the same decision about removing "apache-" from the Solr release archive names (a separate issue from the artifact names).
        Hide
        Robert Muir added a comment -

        my smoker is happy:

             [exec] SUCCESS!
             [exec] 
           [delete] Deleting directory /home/rmuir/workspace/lucene-trunk/lucene/build/fakeRelease
           [delete] Deleting directory /home/rmuir/workspace/lucene-trunk/lucene/build/fakeReleaseTmp
        
        BUILD SUCCESSFUL
        Total time: 27 minutes 40 seconds
        
        Show
        Robert Muir added a comment - my smoker is happy: [exec] SUCCESS! [exec] [delete] Deleting directory /home/rmuir/workspace/lucene-trunk/lucene/build/fakeRelease [delete] Deleting directory /home/rmuir/workspace/lucene-trunk/lucene/build/fakeReleaseTmp BUILD SUCCESSFUL Total time: 27 minutes 40 seconds
        Hide
        Steve Rowe added a comment -

        Mine too (OS X 10.8.2):

             [exec] SUCCESS!
             [exec] 
           [delete] Deleting directory /Users/sarowe/svn/lucene/dev/trunk2/lucene/build/fakeRelease
           [delete] Deleting directory /Users/sarowe/svn/lucene/dev/trunk2/lucene/build/fakeReleaseTmp
        
        BUILD SUCCESSFUL
        Total time: 36 minutes 3 seconds
        
        Show
        Steve Rowe added a comment - Mine too (OS X 10.8.2): [exec] SUCCESS! [exec] [delete] Deleting directory /Users/sarowe/svn/lucene/dev/trunk2/lucene/build/fakeRelease [delete] Deleting directory /Users/sarowe/svn/lucene/dev/trunk2/lucene/build/fakeReleaseTmp BUILD SUCCESSFUL Total time: 36 minutes 3 seconds
        Hide
        Steve Rowe added a comment -

        Patch applies with no change to branch_4x, except for the change to the fullname property value in solr/common-build.xml; I made that change manually and successfully smoked on branch_4x:

             [exec] SUCCESS!
             [exec] 
           [delete] Deleting directory /Users/sarowe/svn/lucene/dev/branches/branch_4x/lucene/build/fakeRelease
           [delete] Deleting directory /Users/sarowe/svn/lucene/dev/branches/branch_4x/lucene/build/fakeReleaseTmp
        
        BUILD SUCCESSFUL
        Total time: 36 minutes 58 seconds
        
        Show
        Steve Rowe added a comment - Patch applies with no change to branch_4x, except for the change to the fullname property value in solr/common-build.xml ; I made that change manually and successfully smoked on branch_4x: [exec] SUCCESS! [exec] [delete] Deleting directory /Users/sarowe/svn/lucene/dev/branches/branch_4x/lucene/build/fakeRelease [delete] Deleting directory /Users/sarowe/svn/lucene/dev/branches/branch_4x/lucene/build/fakeReleaseTmp BUILD SUCCESSFUL Total time: 36 minutes 58 seconds
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1432483

        SOLR-4287: Removed "apache-" prefix from Solr distribution and artifact filenames.

        Show
        Commit Tag Bot added a comment - [trunk commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1432483 SOLR-4287 : Removed "apache-" prefix from Solr distribution and artifact filenames.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1432486

        SOLR-4287: Removed "apache-" prefix from Solr distribution and artifact filenames. (merged trunk r1432483)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1432486 SOLR-4287 : Removed "apache-" prefix from Solr distribution and artifact filenames. (merged trunk r1432483)
        Hide
        Steve Rowe added a comment -

        Committed to trunk and branch_4x.

        Thanks Ryan!

        Show
        Steve Rowe added a comment - Committed to trunk and branch_4x. Thanks Ryan!

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development