Solr
  1. Solr
  2. SOLR-4238

filename pattern of jetty request log file in sample example\etc\jetty.xml is wrong

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:

      Description

      This is being used now:
      <Set name="filenameDateFormat">yyyy_mm_dd</Set>
      but mm means minutes (I guess) and filenames created are not meaningfull. Changing to
      <Set name="filenameDateFormat">yyyy_MM_dd</Set>
      creates proper filenames.

      Note that the logger is commented out by default, but I always enable it.

        Activity

        Hide
        jmlucjav added a comment -

        simple patch with fix

        Show
        jmlucjav added a comment - simple patch with fix
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1427240

        SOLR-4238: Fix jetty example requestLog config

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1427240 SOLR-4238 : Fix jetty example requestLog config
        Hide
        Hoss Man added a comment -

        thanks jm (oddly, your patch changed the "filename" property, but not the "filenameDateFormat" as mentioned in your issue description – from what i can tell those are suppose to be in sync, so i committed both)

        Show
        Hoss Man added a comment - thanks jm (oddly, your patch changed the "filename" property, but not the "filenameDateFormat" as mentioned in your issue description – from what i can tell those are suppose to be in sync, so i committed both)
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1427241

        SOLR-4238: Fix jetty example requestLog config (merge r1427240)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1427241 SOLR-4238 : Fix jetty example requestLog config (merge r1427240)
        Hide
        jmlucjav added a comment -

        Thanks Hos for taking care of this.

        I have to clarify two things:

        1. I changed the wrong property when creating the patch , the only thing I should have changed was as I said in the description:
        <Set name="filenameDateFormat">yyyy_MM_dd</Set>

        2. the reason filename was not changed, is that according to http://stackoverflow.com/questions/11527194/jetty-access-log-is-no-longer-logging is not clear filename must match filenameDateFormat, and that retainDays won't work if you change that format (see Bob Kuhar's comment). And I have verified the filename created is correct when changing just filenameDateFormat

        so not sure you should change filename, up to you.

        jm

        Show
        jmlucjav added a comment - Thanks Hos for taking care of this. I have to clarify two things: 1. I changed the wrong property when creating the patch , the only thing I should have changed was as I said in the description: <Set name="filenameDateFormat">yyyy_MM_dd</Set> 2. the reason filename was not changed, is that according to http://stackoverflow.com/questions/11527194/jetty-access-log-is-no-longer-logging is not clear filename must match filenameDateFormat, and that retainDays won't work if you change that format (see Bob Kuhar's comment). And I have verified the filename created is correct when changing just filenameDateFormat so not sure you should change filename, up to you. jm
        Hide
        Hoss Man added a comment -

        blarg.

        thanks for catching that ... sigh. It would be nice if there wasn't 5,000 diff jetty docs out there with conflicting info.

        Committed revision 1427258.
        Committed revision 1427259.

        Show
        Hoss Man added a comment - blarg. thanks for catching that ... sigh. It would be nice if there wasn't 5,000 diff jetty docs out there with conflicting info. Committed revision 1427258. Committed revision 1427259.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1427258

        SOLR-4238: only fix one place, the other place is suppose to be broken for things to work properly

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1427258 SOLR-4238 : only fix one place, the other place is suppose to be broken for things to work properly
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1427259

        SOLR-4238: only fix one place, the other place is suppose to be broken for things to work properly (merge r1427258)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1427259 SOLR-4238 : only fix one place, the other place is suppose to be broken for things to work properly (merge r1427258)

          People

          • Assignee:
            Hoss Man
            Reporter:
            jmlucjav
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development