Solr
  1. Solr
  2. SOLR-4228

SolrPing - add methods for enable/disable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.4, 6.0
    • Component/s: clients - java
    • Labels:
      None

      Description

      The new PingRequestHandler in Solr 4.0 takes over what actions.jsp used to do in older versions. Create methods in the SolrPing request object to access this capability.

      1. SOLR-4228.patch
        9 kB
        Shawn Heisey
      2. SOLR-4228.patch
        9 kB
        Shawn Heisey
      3. SOLR-4228.patch
        9 kB
        Shawn Heisey
      4. SOLR-4228.patch
        9 kB
        Shawn Heisey
      5. SOLR-4228.patch
        9 kB
        Shawn Heisey
      6. SOLR-4228.patch
        9 kB
        Shawn Heisey
      7. SOLR-4228.patch
        9 kB
        Shawn Heisey
      8. SOLR-4228.patch
        4 kB
        Shawn Heisey

        Activity

        Hide
        Shawn Heisey added a comment -

        Patch implementing three new methods - removeAction, setActionDisable, and setActionEnable

        Show
        Shawn Heisey added a comment - Patch implementing three new methods - removeAction, setActionDisable, and setActionEnable
        Hide
        Shawn Heisey added a comment -

        I didn't find any tests to modify, and not sure how to go about making a new test.

        Show
        Shawn Heisey added a comment - I didn't find any tests to modify, and not sure how to go about making a new test.
        Hide
        Shawn Heisey added a comment -

        In my working copy, I have added a PingRequestHandler to the solrconfig.xml in the shared test files for solrj. If someone can give me the name of an existing test for SolrJ that sets up a full Solr JVM and indexes some data, I'll be happy to copy that test and put together some tests for SolrPing.

        Show
        Shawn Heisey added a comment - In my working copy, I have added a PingRequestHandler to the solrconfig.xml in the shared test files for solrj. If someone can give me the name of an existing test for SolrJ that sets up a full Solr JVM and indexes some data, I'll be happy to copy that test and put together some tests for SolrPing.
        Hide
        Shawn Heisey added a comment -

        I have mostly figured out how to extend SolrJettyTestBase to do a test, but I don't know how to copy or use the solrj test-files with initCore, rather than the example config/schema. I can get it to use the example test/schema, but that doesn't have a health-check file configured, and I don't want to screw around with the example configs, I'd rather adjust the test-files stuff and use it.

        Show
        Shawn Heisey added a comment - I have mostly figured out how to extend SolrJettyTestBase to do a test, but I don't know how to copy or use the solrj test-files with initCore, rather than the example config/schema. I can get it to use the example test/schema, but that doesn't have a health-check file configured, and I don't want to screw around with the example configs, I'd rather adjust the test-files stuff and use it.
        Hide
        Shawn Heisey added a comment -

        New patch with a test that fails because I don't know how to start it with the right solrconfig/schema.

        Show
        Shawn Heisey added a comment - New patch with a test that fails because I don't know how to start it with the right solrconfig/schema.
        Hide
        Shawn Heisey added a comment -

        Previous patch did not actually have the test class. Deleted that attachment. Did svn add and made a new patch.

        Show
        Shawn Heisey added a comment - Previous patch did not actually have the test class. Deleted that attachment. Did svn add and made a new patch.
        Hide
        Shawn Heisey added a comment -

        One more time. Wrong expected exception type on one of the tests.

        Show
        Shawn Heisey added a comment - One more time. Wrong expected exception type on one of the tests.
        Hide
        Shawn Heisey added a comment -

        New patch that adds setActionPing method. Test unchanged, so it still doesn't pass.

        Show
        Shawn Heisey added a comment - New patch that adds setActionPing method. Test unchanged, so it still doesn't pass.
        Hide
        Shawn Heisey added a comment -

        Fulfilling the open source mandate of releasing often.

        Improvements in the unit tests, another failed attempt to get the custom solrconfig loaded.

        Show
        Shawn Heisey added a comment - Fulfilling the open source mandate of releasing often. Improvements in the unit tests, another failed attempt to get the custom solrconfig loaded.
        Hide
        Shawn Heisey added a comment -

        New patch. Now the test passes, but I suspect that I am not using the base class and initCore in the proper way. Left a comment in beforeClass saying so.

        Show
        Shawn Heisey added a comment - New patch. Now the test passes, but I suspect that I am not using the base class and initCore in the proper way. Left a comment in beforeClass saying so.
        Hide
        Shawn Heisey added a comment -

        Comment correction. If my approach to initCore is acceptable, then it's ready for committing. If it's not acceptable, please let me know the right way to do it.

        Show
        Shawn Heisey added a comment - Comment correction. If my approach to initCore is acceptable, then it's ready for committing. If it's not acceptable, please let me know the right way to do it.
        Hide
        Shawn Heisey added a comment -

        Is there any objection to committing this patch after some cleanup and making sure it applies to current trunk/4x? I would like peer review especially of the way that I built the tests and help fixing it if I did it wrong.

        This comment is part of an effort to close old issues that I have reported. Search tag: elyograg2013springclean

        Show
        Shawn Heisey added a comment - Is there any objection to committing this patch after some cleanup and making sure it applies to current trunk/4x? I would like peer review especially of the way that I built the tests and help fixing it if I did it wrong. This comment is part of an effort to close old issues that I have reported. Search tag: elyograg2013springclean
        Hide
        Shawn Heisey added a comment -

        New patch with some cleanups and CHANGES.txt that lists it as a new feature on version 4.4. Like the previous patch versions, it doesn't change default behavior, just adds new capability. On trunk, precommit passes and solr tests are underway. If that works OK, I will commit soon. Before committing to 4x, I will also give it a try in my dev environment.

        Show
        Shawn Heisey added a comment - New patch with some cleanups and CHANGES.txt that lists it as a new feature on version 4.4. Like the previous patch versions, it doesn't change default behavior, just adds new capability. On trunk, precommit passes and solr tests are underway. If that works OK, I will commit soon. Before committing to 4x, I will also give it a try in my dev environment.
        Hide
        Shawn Heisey added a comment -

        Committed to trunk, r1487189. Double-checking branch_4x before committing the backport.

        Show
        Shawn Heisey added a comment - Committed to trunk, r1487189. Double-checking branch_4x before committing the backport.
        Hide
        Shawn Heisey added a comment -

        For the 4x backport, I am getting an unrelated consistent test failure in solr/core. The SolrJ tests pass, including the added test. Precommit passes. Committed, r1487229.

        Show
        Shawn Heisey added a comment - For the 4x backport, I am getting an unrelated consistent test failure in solr/core. The SolrJ tests pass, including the added test. Precommit passes. Committed, r1487229.
        Hide
        Shawn Heisey added a comment -

        Hoss Man pointed out a maven test failure via IRC. Steve Rowe gave me the proper way to init the test. Will commit a fix shortly.

        Show
        Shawn Heisey added a comment - Hoss Man pointed out a maven test failure via IRC. Steve Rowe gave me the proper way to init the test. Will commit a fix shortly.
        Hide
        Shawn Heisey added a comment -

        maven test fix committed.

        trunk: r1487602
        branch_4x: r1487603

        Show
        Shawn Heisey added a comment - maven test fix committed. trunk: r1487602 branch_4x: r1487603
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            Shawn Heisey
            Reporter:
            Shawn Heisey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development