[SOLR-4227] StreamingUpdateSolrServer does not buffer OutputStreamWriter with BufferedWriter, causing encoding explosion

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 4.7, 6.0

Environment

Java 1.6, Linux. I am running SOLR 3.2, but the code doesn't seem different in 3.5.

• Assignee: Shalin Shekhar Mangar
• Reporter: Conrad Herrmann
• Created: 22/Dec/12 13:26
• Updated: 09/May/16 18:47
• Resolved: 06/Feb/14 07:52

Description

org.apache.solr.client.solrj.impl.StreamingUpdateSolrServer line 112 is:
OutputStreamWriter writer = new OutputStreamWriter(out, "UTF-8");
and then we call
req.writeXML( writer );
Because the writer is not buffered, this causes the XML writer to call the UTF-8 encoder for each atom being written, like in org.apache.solr.common.util.XML.writeXML:
out.write('<');
This causes the stream encoder to allocate a char array to hold it, and
sun.nio.cs.StreamEncoder.implWrite allocates a CharBuffer to wrap it. All just for one character.

This is particularly a problem when you have a lot of threads (100?) writing to the SOLR server, they rapidly eat up all the CPU.

It would be helpful to allocate the writer as a BufferedWriter, so encoding only happens when you flush. JavaDoc for OutputStreamWriter recommends this: "For top efficiency, consider wrapping an OutputStreamWriter within a BufferedWriter so as to avoid frequent converter invocations."