Solr
  1. Solr
  2. SOLR-4171

CachingDirectoryFactory should not return any directories after it has been closed.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      If something like the replication handler gets a directory after the factory has been closed, it may not be closed.

        Issue Links

          Activity

          Hide
          Mark Miller added a comment -

          This is on 4.1 as part of the recent merge up of directory as first class issue.

          Show
          Mark Miller added a comment - This is on 4.1 as part of the recent merge up of directory as first class issue.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1420911

          SOLR-4171: add a new release(path) method that can be called after factory shutdown and have unload core use it to remove a directory after a core has been shutdown

          Show
          Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1420911 SOLR-4171 : add a new release(path) method that can be called after factory shutdown and have unload core use it to remove a directory after a core has been shutdown
          Hide
          Mark Miller added a comment -

          patch with the change

          Show
          Mark Miller added a comment - patch with the change
          Hide
          Mark Miller added a comment -

          Im going to change it so that removing a dir persistent storage by path doesn't require that the dir factory be open.

          Show
          Mark Miller added a comment - Im going to change it so that removing a dir persistent storage by path doesn't require that the dir factory be open.
          Hide
          Mark Miller added a comment -

          You can see that this causes an issue with delete the core's directory on unload in a recent test failure.

          Show
          Mark Miller added a comment - You can see that this causes an issue with delete the core's directory on unload in a recent test failure.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1420779

          SOLR-4171: CachingDirectoryFactory should not return any directories after it has been closed.

          Show
          Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1420779 SOLR-4171 : CachingDirectoryFactory should not return any directories after it has been closed.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development