Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4166

LBHttpSolrServer should not ignore specified ResponseParser

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: clients - java
    • Labels:
      None

      Description

      Even when using the constructor specifying which ResponseParser to use, LBHttpSolrServer always uses its internal BinaryResponseParser. This forces anyone who wants to use another parser to extend the LBHttpSolrServer class instead of passing it the desired parser, or even null in order to get the original stream.

      In general, it makes sense to have default values, and BinaryResponseParser is probably the best choice for LBHttpSolrServer, but ignoring the parameter is error prone for users.

      1. patch-4166.txt
        4 kB
        Steve Molloy

        Issue Links

          Activity

          Hide
          smolloy Steve Molloy added a comment -

          Initial patch proposition against trunk of 2012-12-11.

          Show
          smolloy Steve Molloy added a comment - Initial patch proposition against trunk of 2012-12-11.
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1420362

          SOLR-4166: LBHttpSolrServer ignores ResponseParser passed in constructor.

          Show
          commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1420362 SOLR-4166 : LBHttpSolrServer ignores ResponseParser passed in constructor.
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [branch_4x commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1420364

          SOLR-4166: LBHttpSolrServer ignores ResponseParser passed in constructor.

          Show
          commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1420364 SOLR-4166 : LBHttpSolrServer ignores ResponseParser passed in constructor.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Thanks Steve!

          Show
          markrmiller@gmail.com Mark Miller added a comment - Thanks Steve!

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              smolloy Steve Molloy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development