Solr
  1. Solr
  2. SOLR-410

Audit the new ResponseBuilder class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: search
    • Labels:
      None

      Description

      In SOLR-281, we added a ResponseBuilder class to help search components communicate with one another. Before releasing 1.3, we need to make sure this is the best design and that it is an interface we can support in the future.

        Issue Links

          Activity

          Hide
          Yonik Seeley added a comment -

          Ongoing review + changes also applies to search components in general (SearchComponent class, etc).

          I think distributed search is core enough that support should be built into SearchComponent, and anyone should be able to make their SearchComponent that works in both a distributed or non-distributed setup.

          One implication of hooks meant for distributed search is that the number of times a component is called may be undefined (when merging results, one may find they need to make another request for more information).

          Show
          Yonik Seeley added a comment - Ongoing review + changes also applies to search components in general (SearchComponent class, etc). I think distributed search is core enough that support should be built into SearchComponent, and anyone should be able to make their SearchComponent that works in both a distributed or non-distributed setup. One implication of hooks meant for distributed search is that the number of times a component is called may be undefined (when merging results, one may find they need to make another request for more information).
          Hide
          Mike Klaas added a comment -

          Ryan, can this be closed?

          Show
          Mike Klaas added a comment - Ryan, can this be closed?
          Hide
          Grant Ingersoll added a comment -

          Seems like this can be closed. We've (the Solr community) had some running time with it and it seems to work well enough. The stage stuff could be documented a little better, but probably not a show stopper.

          Show
          Grant Ingersoll added a comment - Seems like this can be closed. We've (the Solr community) had some running time with it and it seems to work well enough. The stage stuff could be documented a little better, but probably not a show stopper.

            People

            • Assignee:
              Unassigned
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development