Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4101

Provide a flag to store positions and offsets on fields defined in the schema

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.1, 6.0
        • Component/s: None
        • Labels:
          None

          Description

          This will be useful for highlighters (particularly ones based on interval iterators, see LUCENE-2878)

          1. Text File
            SOLR-4101.patch
            2 kB
            Alan Woodward

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            romseygeek Alan Woodward added a comment -

            I plan on committing this tomorrow, unless anyone has better ideas for the flag name ('storeOffsetsWithPositions' is a bit of a mouthful, but it needs to be obviously different from TermVector offsets).

            Show
            romseygeek Alan Woodward added a comment - I plan on committing this tomorrow, unless anyone has better ideas for the flag name ('storeOffsetsWithPositions' is a bit of a mouthful, but it needs to be obviously different from TermVector offsets).
            Hide
            Permalink
            yseeley@gmail.com Yonik Seeley added a comment -

            +1

            storeOffsetsWithPositions' is a bit of a mouthful

            Yeah, but it's pretty descriptive of what it does (i.e. I won't need to go look up if it's referring to term vector offsets or not).

            options = IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS;

            Now that is a mouthful

            micro-optimization: we should be able to throw an "else" before your "if", right?

            Show
            yseeley@gmail.com Yonik Seeley added a comment - +1 storeOffsetsWithPositions' is a bit of a mouthful Yeah, but it's pretty descriptive of what it does (i.e. I won't need to go look up if it's referring to term vector offsets or not). options = IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS; Now that is a mouthful micro-optimization: we should be able to throw an "else" before your "if", right?
            Hide
            Permalink
            romseygeek Alan Woodward added a comment -

            Committed to trunk: 1412803; branch4x: 1412805

            Thanks for the review, Yonik!

            Show
            romseygeek Alan Woodward added a comment - Committed to trunk: 1412803; branch4x: 1412805 Thanks for the review, Yonik!
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Alan Woodward
            http://svn.apache.org/viewvc?view=revision&revision=1412805

            SOLR-4101: Add storeOffsetsWithPositions flag to SchemaField

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Alan Woodward http://svn.apache.org/viewvc?view=revision&revision=1412805 SOLR-4101 : Add storeOffsetsWithPositions flag to SchemaField
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [trunk commit] Alan Woodward
            http://svn.apache.org/viewvc?view=revision&revision=1412803

            SOLR-4101: Add storeOffsetsWithPositions flag to SchemaField

            Show
            commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Alan Woodward http://svn.apache.org/viewvc?view=revision&revision=1412803 SOLR-4101 : Add storeOffsetsWithPositions flag to SchemaField
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Alan Woodward
            http://svn.apache.org/viewvc?view=revision&revision=1412805

            SOLR-4101: Add storeOffsetsWithPositions flag to SchemaField

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Alan Woodward http://svn.apache.org/viewvc?view=revision&revision=1412805 SOLR-4101 : Add storeOffsetsWithPositions flag to SchemaField

              People

              • Assignee:
                romseygeek Alan Woodward
                Reporter:
                romseygeek Alan Woodward
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development