[SOLR-4098] Unacceptable Corecontainer logic.lead delete/rename/swap a core quietly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 4.0-ALPHA, 4.0-BETA, 4.0
• Component/s: multicore
• Assignee: Mark Miller
• Reporter: Po Rui
• Created: 21/Nov/12 06:09
• Updated: 04/Oct/16 03:18
• Resolved: 04/Oct/16 03:18

Description

a bad logic in CoreContainer. it will assign a default name using checkDefault(name) while the core name is not specified.
e.g.
http://127.0.0.1:8983/solr/admin/cores?action=UNLOAD
or append whatever uncrect param like:
http://127.0.0.1:8983/solr/admin/cores?action=UNLOAD&appname=wop

those request both unload the core "collection1"(cause the default core name is "collection1" in solr)
this bad behavior appear on "reload"/"swap"/"rename"/"remove" and "getCore(String)" operation

here, checkDefault() should throw exception rather than assign a name quietly

I'd fixed rename/remove/reload/swap. but getCore(name) be invoked by too many methods. I'm not sure weather this also lead some potential issue now. I'd rather believe it does. those invoker should be double check in next version