Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: search
    • Labels:
      None

      Description

      The PingRequestHandler checks the healthcheck file first (if configured) and returns an error if the instance is disabled. It then executes the configured ping query to ensure that the index is accessible. Advantages:

      • Enable/Disable and index availability can both be checked by the load balancer via a single URL.
      • The URL accessed by the load balancer is outside /admin, making it easier to restrict access to /admin.
      1. ping-request-handler.patch
        2 kB
        Karsten Sperling
      2. SOLR-408-PingRequestHandler.patch
        8 kB
        Ryan McKinley

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          FWIW I'm in favor of making a separate PingRequestHandler, but i think we should take advantage of this oportunity to eliminate the use of core.getPingQueryRequest() 9and the horrible syntax it depends on)

          This new handler should use it's own init params to drive the query.

          Show
          Hoss Man added a comment - FWIW I'm in favor of making a separate PingRequestHandler, but i think we should take advantage of this oportunity to eliminate the use of core.getPingQueryRequest() 9and the horrible syntax it depends on) This new handler should use it's own init params to drive the query.
          Hide
          Ryan McKinley added a comment -

          agreed - i'll post a modified patch shortly

          Show
          Ryan McKinley added a comment - agreed - i'll post a modified patch shortly
          Hide
          Ryan McKinley added a comment -

          updated your patch to use its own parameters for the ping query.

          Also @Deprecated getPingQueryRequest() and removed it from the example solrconfig.xml

          This configures the PingRequestHandler with:

          <requestHandler name="/admin/ping" class="PingRequestHandler">
          <lst name="defaults">
          <str name="qt">standard</str>
          <str name="q">solrpingquery</str>
          <str name="echoParams">all</str>
          </lst>
          </requestHandler>

          This path overrides the ping.jsp servlet and uses the new request handler.

          Show
          Ryan McKinley added a comment - updated your patch to use its own parameters for the ping query. Also @Deprecated getPingQueryRequest() and removed it from the example solrconfig.xml This configures the PingRequestHandler with: <requestHandler name="/admin/ping" class="PingRequestHandler"> <lst name="defaults"> <str name="qt">standard</str> <str name="q">solrpingquery</str> <str name="echoParams">all</str> </lst> </requestHandler> This path overrides the ping.jsp servlet and uses the new request handler.
          Hide
          Ryan McKinley added a comment -

          thanks Karsten

          Show
          Ryan McKinley added a comment - thanks Karsten

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Karsten Sperling
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development