Solr
  1. Solr
  2. SOLR-4043

Add ability to get success/failure responses from Collections API.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA, 4.0-BETA, 4.0
    • Fix Version/s: 4.2, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Environment:

      Solr cloud cluster

      Description

      The create/delete/reload collections are asynchronous process, the client can't get the right response, only make sure the information have been saved into the OverseerCollectionQueue. The client will get the response directly that don't wait the result of behavior(create/delete/reload collection) whatever successful.

      The easy solution is client wait until the asynchronous process success, the create/delete/reload collection thread will save the response into OverseerCollectionQueue, then notify client to get the response.

      1. patch-4043.txt
        21 kB
        Raintung Li
      2. SOLR-4043_brach4.x.txt
        20 kB
        Raintung Li
      3. SOLR-4043.patch
        25 kB
        Mark Miller

        Issue Links

          Activity

          Hide
          Raintung Li added a comment -

          The patch fix this bug

          Show
          Raintung Li added a comment - The patch fix this bug
          Hide
          Mark Miller added a comment -

          Yeah, this was done on purpose - mainly due to time constraints - def been on my list of things that needs to be improved.

          Show
          Mark Miller added a comment - Yeah, this was done on purpose - mainly due to time constraints - def been on my list of things that needs to be improved.
          Hide
          Mark Miller added a comment -

          Thanks a lot for this patch Raintung! I'm going to try and get it up to date with trunk shortly.

          Show
          Mark Miller added a comment - Thanks a lot for this patch Raintung! I'm going to try and get it up to date with trunk shortly.
          Hide
          Mark Miller added a comment -

          Raintung, is this patch against 4.0 rather than 4x or 5x on Nov 7?

          Show
          Mark Miller added a comment - Raintung, is this patch against 4.0 rather than 4x or 5x on Nov 7?
          Hide
          Raintung Li added a comment -

          Mark, this patch is base on 4.0

          Show
          Raintung Li added a comment - Mark, this patch is base on 4.0
          Hide
          Mark Miller added a comment -

          Reminder to look at the test in SOLR-4114 that uses a 10 second wait. It seems this issue should allow us to test that without the wait in a way that we can be fairly confident?

          Show
          Mark Miller added a comment - Reminder to look at the test in SOLR-4114 that uses a 10 second wait. It seems this issue should allow us to test that without the wait in a way that we can be fairly confident?
          Hide
          Raintung Li added a comment -

          This issue not only let client can get the response without the wait, but also it is important to get the right response from overseer that can make the decision for admin to redo the call.

          Show
          Raintung Li added a comment - This issue not only let client can get the response without the wait, but also it is important to get the right response from overseer that can make the decision for admin to redo the call.
          Hide
          Mark Miller added a comment -

          Hey Raintung - I think this issue is very important! I'm sorry I have not been able to get to it yet. It will take me some time to merge it up to 4x/5x and go over it, but it's high on my priority list!

          Show
          Mark Miller added a comment - Hey Raintung - I think this issue is very important! I'm sorry I have not been able to get to it yet. It will take me some time to merge it up to 4x/5x and go over it, but it's high on my priority list!
          Hide
          Mark Miller added a comment -

          Hey Raintung, if there is any chance you have the time to merge this up to 4x or trunk, that would be extremely helpful!

          Show
          Mark Miller added a comment - Hey Raintung, if there is any chance you have the time to merge this up to 4x or trunk, that would be extremely helpful!
          Hide
          Raintung Li added a comment -

          ok, I will do it in this weekend.

          Show
          Raintung Li added a comment - ok, I will do it in this weekend.
          Hide
          Raintung Li added a comment -

          Merge to branch 4.x

          Show
          Raintung Li added a comment - Merge to branch 4.x
          Hide
          Mark Miller added a comment -

          Thank you Raintung! I will get this in soon.

          Show
          Mark Miller added a comment - Thank you Raintung! I will get this in soon.
          Hide
          Mark Miller added a comment -

          This patch cleans up a bunch of tabs and formatting and fixes the new collections api mock test so that it will pass.

          Show
          Mark Miller added a comment - This patch cleans up a bunch of tabs and formatting and fixes the new collections api mock test so that it will pass.
          Hide
          Mark Miller added a comment -

          I don't dare toss this in last minute for 4.1 unfortunately - I'll keep it up to date, but I think it needs to be pushed to 4.2. The only reason I consider 4.1 is that we already have back compat zk issues, so it might be easier to do this now. But I think bugs are going to take precedence.

          Show
          Mark Miller added a comment - I don't dare toss this in last minute for 4.1 unfortunately - I'll keep it up to date, but I think it needs to be pushed to 4.2. The only reason I consider 4.1 is that we already have back compat zk issues, so it might be easier to do this now. But I think bugs are going to take precedence.
          Hide
          Raintung Li added a comment -

          Actually it is bug, API doesn't return correctly response.

          Show
          Raintung Li added a comment - Actually it is bug, API doesn't return correctly response.
          Hide
          Mark Miller added a comment -

          I suppose you could look at it either way - but the way it currently works was intentional given time and priorities. I look at this as an improvement on that - it was always planned. It will be in 4.2 - but I don't think I'll have time to do a proper vetting for 4.1.

          Show
          Mark Miller added a comment - I suppose you could look at it either way - but the way it currently works was intentional given time and priorities. I look at this as an improvement on that - it was always planned. It will be in 4.2 - but I don't think I'll have time to do a proper vetting for 4.1.
          Hide
          Raintung Li added a comment - - edited

          Got it, it is ok. I know you are very busy. , and how about 4.1 release date?

          Show
          Raintung Li added a comment - - edited Got it, it is ok. I know you are very busy. , and how about 4.1 release date?
          Hide
          Mark Miller added a comment -

          I'm going to commit this in a moment so it can start baking for 4.2.

          Show
          Mark Miller added a comment - I'm going to commit this in a moment so it can start baking for 4.2.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1438550

          SOLR-4043: Add ability to get success/failure responses from Collections API.

          Show
          Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1438550 SOLR-4043 : Add ability to get success/failure responses from Collections API.
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1438555

          SOLR-4043: Add ability to get success/failure responses from Collections API.

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1438555 SOLR-4043 : Add ability to get success/failure responses from Collections API.
          Hide
          Mark Miller added a comment -

          Thanks Raintung! Let's open new JIRA's for anything further needed on this.

          Show
          Mark Miller added a comment - Thanks Raintung! Let's open new JIRA's for anything further needed on this.
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Raintung Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development