Solr
  1. Solr
  2. SOLR-4033

No lockType configured for NRTCachingDirectory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Environment:

      5.0-SNAPSHOT 1366361:1404534M - markus - 2012-11-01 12:37:38
      Debian Squeeze, Tomcat 6, Sun Java 6, 10 nodes, 10 shards, rep. factor 2.

      Issue Links

        Activity

        Hide
        Mark Miller added a comment -

        I'll double check some of this - and perhaps start using a lock - but I suspect this may be benign as long as it's not happening around index file access. I now write a few files through the Directory that don't need to worry about a lock factory (not index stuff).

        Show
        Mark Miller added a comment - I'll double check some of this - and perhaps start using a lock - but I suspect this may be benign as long as it's not happening around index file access. I now write a few files through the Directory that don't need to worry about a lock factory (not index stuff).
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1418712

        SOLR-4033: Consistently use the solrconfig.xml lockType everywhere.

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1418712 SOLR-4033 : Consistently use the solrconfig.xml lockType everywhere.
        Hide
        Mark Miller added a comment -

        Just committed a fix that uses the configured lock type everywhere no matter what. Previously, when not dealing with an index there was a case or two that didn't use it (writing properties files) and places did not use it when it was known that a Directory was already created, so not passing it had no affect. Now we just consistently pass it everywhere - no warning messages, no worries about is it safe to not pass it here, etc.

        Show
        Mark Miller added a comment - Just committed a fix that uses the configured lock type everywhere no matter what. Previously, when not dealing with an index there was a case or two that didn't use it (writing properties files) and places did not use it when it was known that a Directory was already created, so not passing it had no affect. Now we just consistently pass it everywhere - no warning messages, no worries about is it safe to not pass it here, etc.
        Hide
        Shalin Shekhar Mangar added a comment -

        This fix was released in 4.1

        Show
        Shalin Shekhar Mangar added a comment - This fix was released in 4.1

          People

          • Assignee:
            Mark Miller
            Reporter:
            Markus Jelsma
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development