Details
Major
Description
Issue Links
- is related to
-
SOLR-4117
IO error while trying to get the size of the Directory
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
[trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1418712
SOLR-4033: Consistently use the solrconfig.xml lockType everywhere.
Show
Commit Tag Bot
added a comment - [trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1418712
SOLR-4033 : Consistently use the solrconfig.xml lockType everywhere.
Just committed a fix that uses the configured lock type everywhere no matter what. Previously, when not dealing with an index there was a case or two that didn't use it (writing properties files) and places did not use it when it was known that a Directory was already created, so not passing it had no affect. Now we just consistently pass it everywhere - no warning messages, no worries about is it safe to not pass it here, etc.
Show
Mark Miller
added a comment - Just committed a fix that uses the configured lock type everywhere no matter what. Previously, when not dealing with an index there was a case or two that didn't use it (writing properties files) and places did not use it when it was known that a Directory was already created, so not passing it had no affect. Now we just consistently pass it everywhere - no warning messages, no worries about is it safe to not pass it here, etc.
This fix was released in 4.1
Show
Shalin Shekhar Mangar
added a comment - This fix was released in 4.1
I'll double check some of this - and perhaps start using a lock - but I suspect this may be benign as long as it's not happening around index file access. I now write a few files through the Directory that don't need to worry about a lock factory (not index stuff).