[SOLR-3989] RuntimeException thrown by SolrZkClient should wrap cause, have a message, or be SolrException

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1, 6.0
• Component/s: clients - java
• Assignee: Yonik Seeley
• Reporter: Colin Bartolome
• Created: 24/Oct/12 22:22
• Updated: 09/May/16 18:51
• Resolved: 13/Nov/12 00:09

Description

In a few spots, but notably in the constructor for SolrZkClient, a try-catch block will catch Throwable and throw a new RuntimeException with no cause or message. Either the RuntimeException should wrap the Throwable that was caught, some sort of message should be added, or the type of the exception should be changed to SolrException so calling code can catch these exceptions without casting too broad of a net.

Reproduce this by creating a CloudSolrServer that points to a URL that is valid, but has no server running:

CloudSolrServer server = new CloudSolrServer("localhost:9983");

server.connect();