Solr
  1. Solr
  2. SOLR-3985

Allow ExternalFileField caches to be reloaded on newSearcher and firstSearcher events

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, 6.0
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      At the moment, ExternalFileField caches can only be refreshed/reloaded by clearing them entirely, which forces a reload the next time they are used in a query. If your external files are big, this can take unacceptably long.

      Instead, we should allow the caches to be loaded on newSearcher/firstSearcher events, running in the background.

      1. SOLR-3985.patch
        11 kB
        Alan Woodward
      2. SOLR-3985.patch
        11 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Patch, implementing a listener. Also adds some more javadocs to ExternalFileField and FileFloatSource

        Show
        Alan Woodward added a comment - Patch, implementing a listener. Also adds some more javadocs to ExternalFileField and FileFloatSource
        Hide
        Yonik Seeley added a comment -

        Hey Alan, I think this looks fine.
        Could we perhaps remove the "Copyright (c) 2012 Lemur Consulting Ltd."?

        Show
        Yonik Seeley added a comment - Hey Alan, I think this looks fine. Could we perhaps remove the "Copyright (c) 2012 Lemur Consulting Ltd."?
        Hide
        Alan Woodward added a comment -

        Oops, thanks for catching that Yonik. Updated patch, with the correct license header. I'll commit shortly.

        Show
        Alan Woodward added a comment - Oops, thanks for catching that Yonik. Updated patch, with the correct license header. I'll commit shortly.
        Hide
        Alan Woodward added a comment -

        Committed:

        • branch 4x: 1402465
        • trunk: 1402463
        Show
        Alan Woodward added a comment - Committed: branch 4x: 1402465 trunk: 1402463
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Alan Woodward
        http://svn.apache.org/viewvc?view=revision&revision=1402465

        SOLR-3985: Allow ExternalFileField caches to be reloaded on newSearcher/firstSearcher events

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Alan Woodward http://svn.apache.org/viewvc?view=revision&revision=1402465 SOLR-3985 : Allow ExternalFileField caches to be reloaded on newSearcher/firstSearcher events

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development