Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3957

Remove response "WARNING" of "This response format is experimental"

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Remove all the useless (which I daresay is all of them) response WARNINGs stating "This response format is experimental".

      At this point, all of these are more than just experimental, and even if so things are subject to change and in most cases can be done in a compatible manner anyway.

      Less noise.

      1. SOLR-3957.patch
        2 kB
        Erik Hatcher

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        +1

        We can remove for 4.x too, right?

        Show
        yseeley@gmail.com Yonik Seeley added a comment - +1 We can remove for 4.x too, right?
        Hide
        ehatcher Erik Hatcher added a comment -

        patch that removes the experimental warning from both the DIH responses and replication handler details command response. Also removed RequestHandlerUtils.addExperimentalFormatWarning(rsp) method, though maybe it should be kept, or maybe removed on trunk and deprecated on 4x if ported back there?

        Show
        ehatcher Erik Hatcher added a comment - patch that removes the experimental warning from both the DIH responses and replication handler details command response. Also removed RequestHandlerUtils.addExperimentalFormatWarning(rsp) method, though maybe it should be kept, or maybe removed on trunk and deprecated on 4x if ported back there?
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1617651 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1617651 ]

        SOLR-3957: Removed experimental warning from a couple of Solr handlers

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1617651 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1617651 ] SOLR-3957 : Removed experimental warning from a couple of Solr handlers
        Hide
        ehatcher Erik Hatcher added a comment -

        I think best to just do this on trunk/5.0, and leave it alone for 4x. I can't imagine someone relies on it, but maybe someone does have a custom component that calls addExperimentalFormatWarning in which case they'll have to remove it (or clone it) when going to 5.0.

        Show
        ehatcher Erik Hatcher added a comment - I think best to just do this on trunk/5.0, and leave it alone for 4x. I can't imagine someone relies on it, but maybe someone does have a custom component that calls addExperimentalFormatWarning in which case they'll have to remove it (or clone it) when going to 5.0.
        Hide
        anshumg Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            ehatcher Erik Hatcher
            Reporter:
            ehatcher Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development