[SOLR-3911] Make Directory and DirectoryFactory first class so that the majority of Solr's features work with any custom implementations.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1, 6.0
• Assignee: Mark Miller
• Reporter: Mark Miller
• Created: 02/Oct/12 21:32
• Updated: 09/May/16 18:52
• Resolved: 14/Jan/13 03:57

Description

The biggest issue is that many parts of Solr rely on a local file system based Directory implementation - most notably, replication. This should all be changed to use the Directory and DirectoryFactory abstractions.

Other parts of the code that count on the local file system for making paths and getting file sizes should also be changed to use Directory and/or DirectoryFactory.

Original title: Replication should work with any Directory impl, not just local filesystem based Directories.

I've wanted to do this for a long time - there is no reason replication should not support any directory impl. This will let us use the mockdir for replication tests rather than having to force an FSDir and lose all the extra test checks and simulations. This will improve our testing around replication a lot, and allow custom Directory impls to be used on multi node Solr.

Expanded scope - full first class support for DirectoryFactory and Directory.

Issue Links

• is related to: SOLR-4187 CachingDirectoryFactory NPE on release
• is related to: SOLR-4380 ReplicationHandler replicateAfter startup not showing commits after SOLR-3911
• is related to: SOLR-3922 AbstractSolrTestCase duplicates a lot from SolrTestCaseJ4 and is one of the few lines of Solr test classes that do not inherit from SolrTestCaseJ4.
• relates to: SOLR-3665 CoreAdminHandler STATUS command fails when using RAMDirectoryFactory