Solr
  1. Solr
  2. SOLR-3899

SolrCore.getNewIndexDir() always print warning

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
    • Environment:

      Windows 7 x64
      JDK 7u7-x64

      Description

      SolrCore.getNewIndexDir() will always log a warning on the first run. The intention of the check was probably to see if the index dir changed between invocations.

      I provide a SVN patch to solve the problem.

      1. SolrCore.java.patch
        0.6 kB
        Tobias Bergman

        Activity

        Hide
        Mark Miller added a comment -

        I think the behavior is probably fine? Mostly this is just to inform - a change from null to the first dir seems fine to log if you are going to log subsequent changes. No biggie either way.

        This should be info level and not warn IMO though. It's not a situation that warrants warning about.

        Show
        Mark Miller added a comment - I think the behavior is probably fine? Mostly this is just to inform - a change from null to the first dir seems fine to log if you are going to log subsequent changes. No biggie either way. This should be info level and not warn IMO though. It's not a situation that warrants warning about.
        Hide
        Tobias Bergman added a comment -

        Changing the log level to info will also be a good solution. What I wanted was to get rid of the unnecessary warning in the log for each core during startup.

        Show
        Tobias Bergman added a comment - Changing the log level to info will also be a good solution. What I wanted was to get rid of the unnecessary warning in the log for each core during startup.
        Hide
        Mark Miller added a comment -

        Thanks Tobias!

        Show
        Mark Miller added a comment - Thanks Tobias!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1391028

        SOLR-3899: SolrCore should not log at warning level when the index directory changes - it's an info event.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1391028 SOLR-3899 : SolrCore should not log at warning level when the index directory changes - it's an info event.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1391028

        SOLR-3899: SolrCore should not log at warning level when the index directory changes - it's an info event.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1391028 SOLR-3899 : SolrCore should not log at warning level when the index directory changes - it's an info event.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Tobias Bergman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development