Solr
  1. Solr
  2. SOLR-3891

CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package. When implementing a new DirectoryFactory (outside of core) which is a subclass of CDF it may be necessary to use CacheValue (similar to RamDirectoryFactory).

      1. SOLR-3891.patch
        0.7 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        The attached patch makes CacheValue protected rather than default permission.

        Show
        Patrick Hunt added a comment - The attached patch makes CacheValue protected rather than default permission.
        Hide
        Mark Miller added a comment -

        I changed this to a bug - we pretty much intend that you extend CachingDirectoryFactory to make your own, so this is a rather critical oversight for those wishing to impl their own factory.

        It's also a very, very simple change as it just changes visibility from package to protected (and as a result, two variables from package to public).

        Show
        Mark Miller added a comment - I changed this to a bug - we pretty much intend that you extend CachingDirectoryFactory to make your own, so this is a rather critical oversight for those wishing to impl their own factory. It's also a very, very simple change as it just changes visibility from package to protected (and as a result, two variables from package to public).
        Hide
        Mark Miller added a comment -

        Thanks Patrick!

        Show
        Mark Miller added a comment - Thanks Patrick!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1390198

        SOLR-3891: CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390198 SOLR-3891 : CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1390198

        SOLR-3891: CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390198 SOLR-3891 : CacheValue in CachingDirectoryFactory cannot be used outside of solr.core package.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development