Solr
  1. Solr
  2. SOLR-3850

DIH: parameter "cacheKey" was inadvertently renamed "cachePk"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.6.1, 4.0-BETA
    • Fix Version/s: 3.6.2, 4.0
    • Component/s: None
    • Labels:
      None

      Description

      CachedSqlEntityProcessor supports an obscure alternate to the "where" parameter. Instead of <entity ... where='id=x.id' /> , users can use <entity ... cacheKey="id" cacheLookup="x.id" /> However, this was broken with SOLR-2382. "cacheKey" was accidently renamed "cachePk". For the sake of those who might be using this undocumented syntax and want to upgrade, I think it should be put back to "cacheKey". Also, I will add documentation in the wiki.

      1. SOLR-3850.patch
        3 kB
        James Dyer
      2. SOLR-3850.patch
        0.8 kB
        James Dyer

        Activity

        Hide
        James Dyer added a comment -

        I plan to commit this to trunk, 4.x & 3.x shortly.

        Show
        James Dyer added a comment - I plan to commit this to trunk, 4.x & 3.x shortly.
        Hide
        James Dyer added a comment -

        This patch also fixes 2 tests that depended on the incorrect parameter name.

        Show
        James Dyer added a comment - This patch also fixes 2 tests that depended on the incorrect parameter name.
        Hide
        James Dyer added a comment -

        committed.

        Trunk: r1387681
        4x: r1387683
        3x: r1387694

        Also updated the wiki documenting this alternate syntax with a warning about the parameter name being wrong in 3.6, 3.6.1, 4.0-alpha & 4.0-beta.

        Show
        James Dyer added a comment - committed. Trunk: r1387681 4x: r1387683 3x: r1387694 Also updated the wiki documenting this alternate syntax with a warning about the parameter name being wrong in 3.6, 3.6.1, 4.0-alpha & 4.0-beta.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1387683

        SOLR-3850: rename "cachePk" back to "cacheKey"

        Show
        Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1387683 SOLR-3850 : rename "cachePk" back to "cacheKey"
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            James Dyer
            Reporter:
            James Dyer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development