Solr
  1. Solr
  2. SOLR-3838

Admin UI - Multiple filter queries are not supported in Query UI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Implemented
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.4, 6.0
    • Component/s: web gui
    • Labels:
      None

      Description

      The Solr Admin Query UI has only a single "fq" input field, which does not permit the user to enter multiple filter query parameters.

      1. screenshot-1.jpg
        166 kB
        Jack Krupansky
      2. SOLR-3838.patch
        4 kB
        Stefan Matheis (steffkes)
      3. SOLR-3838.patch
        4 kB
        Stefan Matheis (steffkes)
      4. SOLR-3838.patch
        4 kB
        Stefan Matheis (steffkes)
      5. SOLR-3838.patch
        3 kB
        Stefan Matheis (steffkes)

        Activity

        Hide
        Jack Krupansky added a comment -

        Note: The "bq" parameter has the same issue. I could file a separate Jira, but hopefully the fix is easy to do for both at the same time.

        Show
        Jack Krupansky added a comment - Note: The "bq" parameter has the same issue. I could file a separate Jira, but hopefully the fix is easy to do for both at the same time.
        Hide
        Hoss Man added a comment -

        Removing fixVersion=4.0 as this does not seem like a significant enough issue to warrant impeeding momentum towards the (hopefully) rapidly approaching release.

        Show
        Hoss Man added a comment - Removing fixVersion=4.0 as this does not seem like a significant enough issue to warrant impeeding momentum towards the (hopefully) rapidly approaching release.
        Hide
        Stefan Matheis (steffkes) added a comment -

        Like this Jack? If the functionality is okay, that can be applied to other fields as well Only have to know, which ones ..

        Show
        Stefan Matheis (steffkes) added a comment - Like this Jack? If the functionality is okay, that can be applied to other fields as well Only have to know, which ones ..
        Hide
        Jack Krupansky added a comment -

        Okay...

        1. I don't see the "-" buttons - see the screen shot. I checked the style sheet and the referenced file, url(../../img/ico/minus-button.png ), does not exist.

        2. Add fq seems to work fine.

        3. When I had 4 fq's (111, 222, 333, 444) and I clicked where the "-" button should be for the 222 row, it in fact deleted the 222 row, but also deleted the 444 row! Leaving the state shown in the screen shot.

        4. If I fill in a new row/fq and hit Enter, everything is fine, but... then there is no "-" button for that new row. Or maybe that's just because the image file is missing.

        You can see the actual fq's in the XML query response.

        This is Google Chrome.

        Local build of trunk plus the patch.

        Show
        Jack Krupansky added a comment - Okay... 1. I don't see the "-" buttons - see the screen shot. I checked the style sheet and the referenced file, url(../../img/ico/minus-button.png ), does not exist. 2. Add fq seems to work fine. 3. When I had 4 fq's (111, 222, 333, 444) and I clicked where the "-" button should be for the 222 row, it in fact deleted the 222 row, but also deleted the 444 row! Leaving the state shown in the screen shot. 4. If I fill in a new row/fq and hit Enter, everything is fine, but... then there is no "-" button for that new row. Or maybe that's just because the image file is missing. You can see the actual fq's in the XML query response. This is Google Chrome. Local build of trunk plus the patch.
        Hide
        Stefan Matheis (steffkes) added a comment -

        1. I don't see the "-" buttons - see the screen shot. I checked the style sheet and the referenced file, url(../../img/ico/minus-button.png ), does not exist.

        Right, i did forget to svn add the minus-button .. but now it's there.

        3. When I had 4 fq's (111, 222, 333, 444) and I clicked where the "-" button should be for the 222 row, it in fact deleted the 222 row, but also deleted the 444 row! Leaving the state shown in the screen shot.

        Ah great, thanks for pointing that out .. clearing the input's value is of course only meant to happen, when you add a new row – fixed this.

        4. If I fill in a new row/fq and hit Enter, everything is fine, but... then there is no "-" button for that new row. Or maybe that's just because the image file is missing.

        It is only not shown because the icon is actually not yet there. the idea was .. having the [+] sign only at the last row, all others would have a [-] to allow this row to be deleted, should make sense?

        Show
        Stefan Matheis (steffkes) added a comment - 1. I don't see the "-" buttons - see the screen shot. I checked the style sheet and the referenced file, url(../../img/ico/minus-button.png ), does not exist. Right, i did forget to svn add the minus-button .. but now it's there. 3. When I had 4 fq's (111, 222, 333, 444) and I clicked where the "-" button should be for the 222 row, it in fact deleted the 222 row, but also deleted the 444 row! Leaving the state shown in the screen shot. Ah great, thanks for pointing that out .. clearing the input's value is of course only meant to happen, when you add a new row – fixed this. 4. If I fill in a new row/fq and hit Enter, everything is fine, but... then there is no "-" button for that new row. Or maybe that's just because the image file is missing. It is only not shown because the icon is actually not yet there. the idea was .. having the [+] sign only at the last row, all others would have a [-] to allow this row to be deleted, should make sense?
        Hide
        Jack Krupansky added a comment -

        So, how do I get the minus-button.png file?? I mean, I applied the patch without errors, but where is that file?

        Show
        Jack Krupansky added a comment - So, how do I get the minus-button.png file?? I mean, I applied the patch without errors, but where is that file?
        Hide
        Stefan Matheis (steffkes) added a comment -

        It's a binary file .. so the only thing in the patch is a remark for svn .. but never the real file, sorry Jack (:
        But if you want to give it a try, it will be this Icon: https://raw.github.com/yusukekamiyamane/fugue-icons/master/icons/minus-button.png

        Show
        Stefan Matheis (steffkes) added a comment - It's a binary file .. so the only thing in the patch is a remark for svn .. but never the real file, sorry Jack (: But if you want to give it a try, it will be this Icon: https://raw.github.com/yusukekamiyamane/fugue-icons/master/icons/minus-button.png
        Hide
        Jack Krupansky added a comment - - edited

        Okay, it all seems to work.

        My only real complaint is that I can't delete the last entry except by manually deleting the text itself or hitting an extra "+" and then I get a "-" button to delete the last entry. And if I do manually delete the text of the last entry, I have this annoying empty box that can't be deleted. And if I hit refresh, everything gets reset.

        I am not a UI designer, but it might be nicer to have both "+" and "-" on each row. The "-" would let me delete the last row, and the "+" on the non-last rows would insert a blank row after the current row. If there is only one row left, "-" would simply clear its text but leave it.

        Is there any way for me to capture a query after I have gone though all this trouble to create it? I mean, why not store the parameters in the display URL so I can copy and paste it?

        Show
        Jack Krupansky added a comment - - edited Okay, it all seems to work. My only real complaint is that I can't delete the last entry except by manually deleting the text itself or hitting an extra "+" and then I get a "-" button to delete the last entry. And if I do manually delete the text of the last entry, I have this annoying empty box that can't be deleted. And if I hit refresh, everything gets reset. I am not a UI designer, but it might be nicer to have both "+" and "-" on each row. The "-" would let me delete the last row, and the "+" on the non-last rows would insert a blank row after the current row. If there is only one row left, "-" would simply clear its text but leave it. Is there any way for me to capture a query after I have gone though all this trouble to create it? I mean, why not store the parameters in the display URL so I can copy and paste it?
        Hide
        Stefan Matheis (steffkes) added a comment -

        I am not a UI designer, but it might be nicer to have both "" and "" on each row. The "" would let me delete the last row, and the "" on the non-last rows would insert a blank row after the current row. If there is only one row left, "-" would simply clear its text but leave it.

        Me neither Jack *g [-] and [+] Buttons appear now for every row, handling as you've described it.

        Is there any way for me to capture a query after I have gone though all this trouble to create it? I mean, why not store the parameters in the display URL so I can copy and paste it?

        The right side of the screen (specifically the bar on top, over the result) provides you with a link .. at least a link to the final result.

        of course this does not bring up the query interface with all the values you may have had, but this opens another whole *g so, would you mind we handle this in another issue?

        Show
        Stefan Matheis (steffkes) added a comment - I am not a UI designer, but it might be nicer to have both " " and " " on each row. The " " would let me delete the last row, and the " " on the non-last rows would insert a blank row after the current row. If there is only one row left, "-" would simply clear its text but leave it. Me neither Jack *g [-] and [+] Buttons appear now for every row, handling as you've described it. Is there any way for me to capture a query after I have gone though all this trouble to create it? I mean, why not store the parameters in the display URL so I can copy and paste it? The right side of the screen (specifically the bar on top, over the result) provides you with a link .. at least a link to the final result. of course this does not bring up the query interface with all the values you may have had, but this opens another whole *g so, would you mind we handle this in another issue?
        Hide
        Stefan Matheis (steffkes) added a comment -

        Jack Krupansky would you mind having another look, if you think it works that way? I'd like to commit this in the next days

        Show
        Stefan Matheis (steffkes) added a comment - Jack Krupansky would you mind having another look, if you think it works that way? I'd like to commit this in the next days
        Hide
        Jack Krupansky added a comment - - edited

        Just tested it (on trunk.) Looks great!

        One tiny nit: After clicking a delete button, the focus is not set, so the Enter key doesn't execute the query - I have to select a box or explicitly click Execute Query. I think the focus should be moved to the last visible fq input box.

        Show
        Jack Krupansky added a comment - - edited Just tested it (on trunk.) Looks great! One tiny nit: After clicking a delete button, the focus is not set, so the Enter key doesn't execute the query - I have to select a box or explicitly click Execute Query. I think the focus should be moved to the last visible fq input box.
        Hide
        Stefan Matheis (steffkes) added a comment -

        Updated Patch, includes the "focus on last possible row after deletion"-change.

        will commit that shortly

        Show
        Stefan Matheis (steffkes) added a comment - Updated Patch, includes the "focus on last possible row after deletion"-change. will commit that shortly
        Hide
        Stefan Matheis (steffkes) added a comment -

        Committed in ..
        trunk: r1494762
        branch_4x: r1494763

        Show
        Stefan Matheis (steffkes) added a comment - Committed in .. trunk: r1494762 branch_4x: r1494763
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            Stefan Matheis (steffkes)
            Reporter:
            Jack Krupansky
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development