Solr
  1. Solr
  2. SOLR-3828

Query Elevation component boosts excluded results in markExcludes mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.0, 6.0
    • Labels:
      None

      Description

      Query Elevation component boosts excluded results in markExcludes=true mode causing them to be higher on results than they should.

      1. SOLR-3828.patch
        6 kB
        Alexey Serba

        Activity

        Hide
        Alexey Serba added a comment -

        Attached patch (fix + test).

        Show
        Alexey Serba added a comment - Attached patch (fix + test).
        Hide
        Hoss Man added a comment -

        Looking back at SOLR-2977 and r1222234 where these lines of code were added, i think it was just a brain fart on grant's part – he introduced a code branch in a place where (previously) BooleanClauses were always added with MUST_NOT and now that he didn't wnat to actaully exclude them, just mark them, he cloned that code and had it use SHOULD instead.

        but i agree, that doesn't make any sense – the set of results using markExclude=true should be the same as the set of results you get not using the elevation component at all, and the scores of the excluded docs shouldn't change.

        Committed revision 1384567.
        Committed revision 1384577. - 4x

        Thanks for finding this and providing the test alexey!

        Show
        Hoss Man added a comment - Looking back at SOLR-2977 and r1222234 where these lines of code were added, i think it was just a brain fart on grant's part – he introduced a code branch in a place where (previously) BooleanClauses were always added with MUST_NOT and now that he didn't wnat to actaully exclude them, just mark them, he cloned that code and had it use SHOULD instead. but i agree, that doesn't make any sense – the set of results using markExclude=true should be the same as the set of results you get not using the elevation component at all, and the scores of the excluded docs shouldn't change. Committed revision 1384567. Committed revision 1384577. - 4x Thanks for finding this and providing the test alexey!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1384577

        SOLR-3828: Fixed QueryElevationComponent so that using 'markExcludes' does not modify the result set or ranking of 'excluded' documents relative to not using elevation at all (merge r1384567)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1384577 SOLR-3828 : Fixed QueryElevationComponent so that using 'markExcludes' does not modify the result set or ranking of 'excluded' documents relative to not using elevation at all (merge r1384567)
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Alexey Serba
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development