Solr
  1. Solr
  2. SOLR-3809

Replication of config files fails when using sub directories

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      If you want to replicate a configuration file inside a subdirectory of conf directory (eg conf/stopwords/english.txt) Solr fails because it cannot find the subdirectory.

      1. SOLR-3809.patch
        3 kB
        Hoss Man
      2. SOLR-3809.patch
        0.6 kB
        Emmanuel Espina

        Activity

        Hide
        Emmanuel Espina added a comment -

        Fixes this bug creating sub directories

        Show
        Emmanuel Espina added a comment - Fixes this bug creating sub directories
        Hide
        Erik Hatcher added a comment -

        Emmanuel - I don't think you meant to mark this as "fixed" - we do that after the issue has the patches committed.

        Show
        Erik Hatcher added a comment - Emmanuel - I don't think you meant to mark this as "fixed" - we do that after the issue has the patches committed.
        Hide
        Emmanuel Espina added a comment -

        oh sorry. I didn't know that

        Show
        Emmanuel Espina added a comment - oh sorry. I didn't know that
        Hide
        Hoss Man added a comment -

        Ouch!

        We should definitely fix this for 4x since the example evne suggests/encourages a "conf/lang/" subdir.

        Emmanuel: I don't suppose you could also help add a test for this in the existing SnapPuller tests? (i haven't looked at them in depth, but i'm assuming there's something in there about ensuring that a config file gets replicated, hopefully it will be simple to just introduce a new dir into the existing test and see it fail)

        Show
        Hoss Man added a comment - Ouch! We should definitely fix this for 4x since the example evne suggests/encourages a "conf/lang/" subdir. Emmanuel: I don't suppose you could also help add a test for this in the existing SnapPuller tests? (i haven't looked at them in depth, but i'm assuming there's something in there about ensuring that a config file gets replicated, hopefully it will be simple to just introduce a new dir into the existing test and see it fail)
        Hide
        Hoss Man added a comment -

        i modified TestReplicationHandler to demonstrate the original bug Emma mentioned, and then merged in his patch to show that it fixed the problem – however i then modified the fix quite a bit, as it was doing some wonky stuff (like equality comparisons between a string path and a File object)

        I think this patch is good to go.

        Show
        Hoss Man added a comment - i modified TestReplicationHandler to demonstrate the original bug Emma mentioned, and then merged in his patch to show that it fixed the problem – however i then modified the fix quite a bit, as it was doing some wonky stuff (like equality comparisons between a string path and a File object) I think this patch is good to go.
        Hide
        Hoss Man added a comment -

        Committed revision 1384492.
        Committed revision 1384501. - 4x

        thanks again emma

        Show
        Hoss Man added a comment - Committed revision 1384492. Committed revision 1384501. - 4x thanks again emma
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1384501

        SOLR-3809: Fixed config file replication when subdirectories are used (merge r1384492)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1384501 SOLR-3809 : Fixed config file replication when subdirectories are used (merge r1384492)
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Emmanuel Espina
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development