Solr
  1. Solr
  2. SOLR-3795

/admin/luke?show=schema is returning raw toString of SchemaField and CopyField objects for "copyDests" and "copySources"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: web gui
    • Labels:
      None

      Description

      While looking into SOLR-3734 i noticed that the LukeRequestHandler is blindly putting arrays of CopyField and SchemaField objects in the response, when returning copy from/to info, which are then getting written out using their toString.

      steffkes seems to have done a great job of parsing the field name out of the SchemaField.toString, but the CopyField.toString info is useless – and clients shouldn't have to do special string parsing to pull out this info.

      I think we should just fix both of these arrays to just be the simple string values that they were most likely intended to be

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          discovered a slightly larger problem dealing with dynamic copyFiels that i spun off into SOLR-3798

          Show
          Hoss Man added a comment - discovered a slightly larger problem dealing with dynamic copyFiels that i spun off into SOLR-3798
          Hide
          Hoss Man added a comment -

          patch that fixes LukeRequestHandler to return just the names for copyDests and copySources and includes a test case (part of which is commented out because of SOLR-3798)

          amazingly: this change doesn't totally break the admin ui, which leads me to believe steffkes is even more awesome then i realized, and must have made it assume the strings re field names it if can't "parse" them using the bogus absurd "toString" format.

          I consider this a bug fix, and would definitley like to commit unless stefkes says that it does in fact break the UI in some way i'm not yet realizing.

          Show
          Hoss Man added a comment - patch that fixes LukeRequestHandler to return just the names for copyDests and copySources and includes a test case (part of which is commented out because of SOLR-3798 ) amazingly: this change doesn't totally break the admin ui, which leads me to believe steffkes is even more awesome then i realized, and must have made it assume the strings re field names it if can't "parse" them using the bogus absurd "toString" format. I consider this a bug fix, and would definitley like to commit unless stefkes says that it does in fact break the UI in some way i'm not yet realizing.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Perfectly fine Hoss, go ahead!

          Show
          Stefan Matheis (steffkes) added a comment - Perfectly fine Hoss, go ahead!
          Hide
          Hoss Man added a comment -

          Committed revision 1381685. 4x
          Committed revision 1381691. trunk

          Show
          Hoss Man added a comment - Committed revision 1381685. 4x Committed revision 1381691. trunk
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Chris M. Hostetter
          http://svn.apache.org/viewvc?view=revision&revision=1381691

          SOLR-3795: Fixed LukeRequestHandler response to correctly return field name strings in copyDests and copySources arrays (merge r1381685)

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1381691 SOLR-3795 : Fixed LukeRequestHandler response to correctly return field name strings in copyDests and copySources arrays (merge r1381685)
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development