Solr
  1. Solr
  2. SOLR-3777

dataimporthandler interface does not send 'false' for unchecked checkboxes. Index is 'clean'ed every time

    Details

      Description

      The checkboxes for 'verbose', 'clean', 'optimize', 'commit' are only sent as arguments when checked. Clearing the checkbox has no effect, so unintended operations are conducted.

      1. SOLR-3777.patch
        0.7 kB
        Stefan Matheis (steffkes)
      2. SOLR-3777.patch
        0.8 kB
        Glenn MacStravic

        Activity

        Hide
        Glenn MacStravic added a comment -

        This sends 'false' for all unchecked checkboxes

        Show
        Glenn MacStravic added a comment - This sends 'false' for all unchecked checkboxes
        Hide
        Hoss Man added a comment -

        steffkes, can you review this patch?

        any other places in the UI where similar bugs might be lurking?

        Show
        Hoss Man added a comment - steffkes, can you review this patch? any other places in the UI where similar bugs might be lurking?
        Hide
        Robert Muir added a comment -

        I'm not a javascript expert: can someone review the patch here?

        Show
        Robert Muir added a comment - I'm not a javascript expert: can someone review the patch here?
        Hide
        Stefan Matheis (steffkes) added a comment -

        Yepp, i'll do so today

        Show
        Stefan Matheis (steffkes) added a comment - Yepp, i'll do so today
        Hide
        Stefan Matheis (steffkes) added a comment -

        updated patch, same functionality using lucene codestyle

        Show
        Stefan Matheis (steffkes) added a comment - updated patch, same functionality using lucene codestyle
        Hide
        Stefan Matheis (steffkes) added a comment -

        Committed revision 1387467. trunk
        Committed revision 1387468. branch_4x

        Show
        Stefan Matheis (steffkes) added a comment - Committed revision 1387467. trunk Committed revision 1387468. branch_4x
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Stefan Matheis
        http://svn.apache.org/viewvc?view=revision&revision=1387468

        SOLR-3777: Dataimport-UI does not send unchecked checkboxes (merge r1387467)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1387468 SOLR-3777 : Dataimport-UI does not send unchecked checkboxes (merge r1387467)
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.
        Hide
        Aaron Greenspan added a comment -

        I've still been having this problem with Solr 4.4.0 and Solr 4.6.0. It's maddening. The word "clean" does not at all imply that it will destroy your entire core, even if you are only trying to work on a single entity within that core, which is what is clearly suggested by selecting an entity from the combo box. In other words, this user interface is exactly the opposite of what it should be in an ideal situation: there is a poorly-labeled check box, for some reason always selected by default (after the user chooses it once apparently), that will delete all of your data.

        Show
        Aaron Greenspan added a comment - I've still been having this problem with Solr 4.4.0 and Solr 4.6.0. It's maddening. The word "clean" does not at all imply that it will destroy your entire core, even if you are only trying to work on a single entity within that core, which is what is clearly suggested by selecting an entity from the combo box. In other words, this user interface is exactly the opposite of what it should be in an ideal situation: there is a poorly-labeled check box, for some reason always selected by default (after the user chooses it once apparently), that will delete all of your data.

          People

          • Assignee:
            Stefan Matheis (steffkes)
            Reporter:
            Glenn MacStravic
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development