Solr
  1. Solr
  2. SOLR-3746

updateLog should fail to init if there is no _version_ field in schema.xml

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA, 4.0-BETA
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Per irc conversation with yonik, it's not clear if updateLog works correctly in all situations if there is no _version_ field in the schema...

      • it's certainly not tested
      • SOLR-3432 makes it clear there are at least some problematic sitautions

      For these reasons, updateLog initialization should fail fast with a clear error if there is no _version_ field in the schema.

      (we can always relax this restriction later if people write the code/tests for it)

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          fix formatting of description

          Show
          Hoss Man added a comment - fix formatting of description
          Hide
          Hoss Man added a comment -

          patch updating the VersionInfo class to throw an exception if the version field doesn't exist, and a test proving that this now causes SolrCore to fail to initialize if updateLog is configured but there is no version field.

          (This also fixes some places in SolrCore where helpful error messages from plugin initialization were being hidden by getting wrapped in InvocationTargetException)

          Show
          Hoss Man added a comment - patch updating the VersionInfo class to throw an exception if the version field doesn't exist, and a test proving that this now causes SolrCore to fail to initialize if updateLog is configured but there is no version field. (This also fixes some places in SolrCore where helpful error messages from plugin initialization were being hidden by getting wrapped in InvocationTargetException)
          Hide
          Hoss Man added a comment -

          Committed revision 1375674.
          Committed revision 1375690.

          Show
          Hoss Man added a comment - Committed revision 1375674. Committed revision 1375690.
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development