Solr
  1. Solr
  2. SOLR-3730

Rollback is not implemented quite right and can cause corner case fails in SolrCloud tests.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Rollback was calling a rollback and then close rather than just a rollback - an oversight on my part - somehow this allowed two indexwriters to be open at once in some seemingly rare cases...this could cause havoc and was easy to miss due to tests using the single lock type.

        Activity

        Hide
        Mark Miller added a comment -

        To clarify, the havoc was generally test havoc - SolrCloud recovery always moves to a new index folder, so issues with the old index folder are not a 'real' problem - caused strange things in tests though. Std recovery may have been affected, but I have not seen a case yet.

        Show
        Mark Miller added a comment - To clarify, the havoc was generally test havoc - SolrCloud recovery always moves to a new index folder, so issues with the old index folder are not a 'real' problem - caused strange things in tests though. Std recovery may have been affected, but I have not seen a case yet.
        Hide
        Mark Miller added a comment -

        So somehow this screwed up ref counting (which had anther problem as well - rollback did not release the dir) - that combined with mock dir opening a writer when you close a dir seemed to be most of the issue here. So a lot of it test related, but real bugs overall.

        Show
        Mark Miller added a comment - So somehow this screwed up ref counting (which had anther problem as well - rollback did not release the dir) - that combined with mock dir opening a writer when you close a dir seemed to be most of the issue here. So a lot of it test related, but real bugs overall.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development