[SOLR-3693] SimpleFacets leak threads

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: faceting
• Assignee: Unassigned
• Reporter: Dawid Weiss
• Created: 31/Jul/12 08:28
• Updated: 04/Jan/18 21:55

Description

  static final Executor facetExecutor = new ThreadPoolExecutor(
          0,
          Integer.MAX_VALUE,
          10, TimeUnit.SECONDS, // terminate idle threads after 10 sec
          new SynchronousQueue<Runnable>()  // directly hand off tasks
          , new DefaultSolrThreadFactory("facetExectutor")
  );

This is created once and never shut down.

I start wondering if it makes sense to add a filter to ignore things like this (which seems to be legitimate). We can either add longer lingering (10 seconds is awfully long though) or we can ignore such cases by thread name (there is a typo in 'facetExecutor' btw).

Let me know what you think.