Solr
  1. Solr
  2. SOLR-3629

core `config` attribute not persisted properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA, 6.0
    • Fix Version/s: 4.0-BETA
    • Component/s: None
    • Labels:
      None

      Description

      If a custom config filename is set CoreContainer persists it as `conf` but attempts to read it as `config`. This results in an exception saying that solrconfig.xml cannot be found--as it has reverted to searching for the default. The work-around is to not set a custom config filename.

      I noticed this both in trunk and branch_4x on the GitHub mirror.

      1. SOLR-3629.patch
        6 kB
        Hoss Man
      2. SOLR-3629.patch
        0.7 kB
        Ryan Zezeski

        Issue Links

          Activity

          Hide
          Ryan Zezeski added a comment -

          I generated this patch by modifying the git-format-patch output. I realize this is not the precise way to contribute a patch but it was the path of least resistance.

          Show
          Ryan Zezeski added a comment - I generated this patch by modifying the git-format-patch output. I realize this is not the precise way to contribute a patch but it was the path of least resistance.
          Hide
          Hoss Man added a comment -

          Ryan: thanks for catching this, and for the patch.

          (I'll look at commiting this tomorow when i have the code in front of me)

          Show
          Hoss Man added a comment - Ryan: thanks for catching this, and for the patch. (I'll look at commiting this tomorow when i have the code in front of me)
          Hide
          Hoss Man added a comment -

          revised patch, switching a lot of duplicated literals to use constants so we don't get bit by this anywhere else.

          The "roles" attribute smells fishy to me, i only see one usage of it ... need to ask miller if this is a bug

          Show
          Hoss Man added a comment - revised patch, switching a lot of duplicated literals to use constants so we don't get bit by this anywhere else. The "roles" attribute smells fishy to me, i only see one usage of it ... need to ask miller if this is a bug
          Hide
          Hoss Man added a comment -

          Thanks for catching this Ryan.

          Committed revision 1363161. - trunk
          Committed revision 1363165. - 4x

          Show
          Hoss Man added a comment - Thanks for catching this Ryan. Committed revision 1363161. - trunk Committed revision 1363165. - 4x

            People

            • Assignee:
              Hoss Man
              Reporter:
              Ryan Zezeski
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development