Solr
  1. Solr
  2. SOLR-3597

seems like a lot of wasted whitespace at the top of the admin screens

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0
    • Component/s: web gui
    • Labels:
      None

      Description

      because of how the UI is laid out, the solr logo is all by itself above the main table, leaving a lot of whitespace to the right of the solr logo.

      this seems like a waste that should be easily curable?

      1. error-divs-overlap.png
        64 kB
        Hoss Man
      2. SOLR-3597.patch
        3 kB
        Stefan Matheis (steffkes)
      3. SOLR-3597.patch
        3 kB
        Stefan Matheis (steffkes)
      4. SOLR-3597-hack.patch
        0.8 kB
        Hoss Man

        Activity

        Hide
        Hoss Man added a comment -

        here is a very hackish patch i reverse engineered using the DOM Inspector in firefox.

        most likely this patch shouldn't be used as is w/o other CSS changes or what not – in particularly i just kind of left the <p id="environment"> </p> paragraph sitting there above the "main" box, and i supsect that if we are going to move the logo like this, that para tag should move somewhere else ... which would then raise questions about wether the "wrapper" div is still needed, which i'm sure affects css, etc...

        the point is i'm posting it wo you can see the end result i'm advocating for, not because i think this is the right way to get that end result

        (tangent: it's not really clear to me what that "environment" para is for. i see javascript that either populates it or kills it depending on what it finds in the command line args, but it's not really clear to my why those specific args are special ... is this doc'ed anywhere? .. even just an HTML/javascript comment explaining what the deal is would be helpful)

        Show
        Hoss Man added a comment - here is a very hackish patch i reverse engineered using the DOM Inspector in firefox. most likely this patch shouldn't be used as is w/o other CSS changes or what not – in particularly i just kind of left the <p id="environment"> </p> paragraph sitting there above the "main" box, and i supsect that if we are going to move the logo like this, that para tag should move somewhere else ... which would then raise questions about wether the "wrapper" div is still needed, which i'm sure affects css, etc... the point is i'm posting it wo you can see the end result i'm advocating for, not because i think this is the right way to get that end result (tangent: it's not really clear to me what that "environment" para is for. i see javascript that either populates it or kills it depending on what it finds in the command line args, but it's not really clear to my why those specific args are special ... is this doc'ed anywhere? .. even just an HTML/javascript comment explaining what the deal is would be helpful)
        Hide
        Stefan Matheis (steffkes) added a comment -

        (tangent: it's not really clear to me what that "environment" para is for. i see javascript that either populates it or kills it depending on what it finds in the command line args, but it's not really clear to my why those specific args are special ... is this doc'ed anywhere? .. even just an HTML/javascript comment explaining what the deal is would be helpful)

        this was suggested in the early days of the new UI, here: http://www.lucidimagination.com/search/document/5fb42ac7b35091a2 - but you're right, it's not clearly documented somewhere else.

        Show
        Stefan Matheis (steffkes) added a comment - (tangent: it's not really clear to me what that "environment" para is for. i see javascript that either populates it or kills it depending on what it finds in the command line args, but it's not really clear to my why those specific args are special ... is this doc'ed anywhere? .. even just an HTML/javascript comment explaining what the deal is would be helpful) this was suggested in the early days of the new UI, here: http://www.lucidimagination.com/search/document/5fb42ac7b35091a2 - but you're right, it's not clearly documented somewhere else.
        Hide
        Stefan Matheis (steffkes) added a comment -

        I really like this change! No idea why the header was left untouched while other things also changed .. but this looks really good (at least for me).

        .. and i supsect that if we are going to move the logo like this, that para tag should move somewhere else ...

        played around with the structure, what may fit is: moving the complete header block inside the menu-wrapper. with the current stylesheet the environment box is moved to the top, but disabling the position-definition in css would help. then we would have (see the following as a screen mock):

        [logo]
        [enviroment]
        [navigation]

        in that case the navigation will move a bit down, but that should be okay.

        most likely this patch shouldn't be used as is w/o other CSS changes or what not

        i'll try to have a look at the weekend (beside finishing a few other patches ;o)

        Show
        Stefan Matheis (steffkes) added a comment - I really like this change! No idea why the header was left untouched while other things also changed .. but this looks really good (at least for me). .. and i supsect that if we are going to move the logo like this, that para tag should move somewhere else ... played around with the structure, what may fit is: moving the complete header block inside the menu-wrapper. with the current stylesheet the environment box is moved to the top, but disabling the position-definition in css would help. then we would have (see the following as a screen mock): [logo] [enviroment] [navigation] in that case the navigation will move a bit down, but that should be okay. most likely this patch shouldn't be used as is w/o other CSS changes or what not i'll try to have a look at the weekend (beside finishing a few other patches ;o)
        Hide
        Hoss Man added a comment -

        bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

        Show
        Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
        Hide
        Stefan Matheis (steffkes) added a comment -

        another approach for solving this problem. moving the header-element into the menu causes problems if we are showing an error-screen because therefore all "-wrapper" elements are removed.

        Show
        Stefan Matheis (steffkes) added a comment - another approach for solving this problem. moving the header-element into the menu causes problems if we are showing an error-screen because therefore all "-wrapper" elements are removed.
        Hide
        Robert Muir added a comment -

        rmuir20120906-bulk-40-change

        Show
        Robert Muir added a comment - rmuir20120906-bulk-40-change
        Hide
        Hoss Man added a comment -

        steffkes: your patch looks great o nthe normal screens, but the one thing i noticed is that on the "you have no cores" error screen, if the reason you have no cores is because of a core init failure, then the failure overlaps with the logo (see attached image)

        Show
        Hoss Man added a comment - steffkes: your patch looks great o nthe normal screens, but the one thing i noticed is that on the "you have no cores" error screen, if the reason you have no cores is because of a core init failure, then the failure overlaps with the logo (see attached image)
        Hide
        Stefan Matheis (steffkes) added a comment -

        Right, didn't notice that .. updated Patch attached

        Show
        Stefan Matheis (steffkes) added a comment - Right, didn't notice that .. updated Patch attached
        Hide
        Hoss Man added a comment -

        Awe-some.

        commit! commit!

        Show
        Hoss Man added a comment - Awe-some. commit! commit!
        Hide
        Stefan Matheis (steffkes) added a comment -

        Done

        Committed revision 1381494. trunk
        Committed revision 1381501. 4x

        Show
        Stefan Matheis (steffkes) added a comment - Done Committed revision 1381494. trunk Committed revision 1381501. 4x
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Stefan Matheis
        http://svn.apache.org/viewvc?view=revision&revision=1381501

        SOLR-3597: admin ui using less whitespace at the top

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1381501 SOLR-3597 : admin ui using less whitespace at the top
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Stefan Matheis (steffkes)
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development