Solr
  1. Solr
  2. SOLR-359

LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: clients - java
    • Labels:
      None

      Description

      The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

      1. SOLR-359.patch
        14 kB
        Grant Ingersoll
      2. SOLR-359-v2.patch
        22 kB
        Grant Ingersoll

        Activity

        Hide
        Grant Ingersoll added a comment -

        First draft of a patch:

        Added FieldFlag.java to common package to share field flag information between the LukeReqHandler and the LukeResponse

        Added to the LukeResponse to extract the flags information for each field and make it available in the Response.

        Also exposed the indexInfo NamedList through a getter, since there are still other pieces of info that are not exposed, most notably the detailed information on each of the FieldTypes.

        Show
        Grant Ingersoll added a comment - First draft of a patch: Added FieldFlag.java to common package to share field flag information between the LukeReqHandler and the LukeResponse Added to the LukeResponse to extract the flags information for each field and make it available in the Response. Also exposed the indexInfo NamedList through a getter, since there are still other pieces of info that are not exposed, most notably the detailed information on each of the FieldTypes.
        Hide
        Grant Ingersoll added a comment -

        Not major, wish the default for JIRA was not major

        Show
        Grant Ingersoll added a comment - Not major, wish the default for JIRA was not major
        Hide
        Grant Ingersoll added a comment -

        I am working on extending the LukeRequestHandler (LRH) and the LukeResponse to give more info about the FieldTypes. Right now, the LRH returns the name of the FieldType, but does not return the class name. Also, I would like to return back more structured access to the FieldType information by extracting it from the IndexInfo in the same way the FieldInfo does now.

        Currently, I am mirroring what is done for the FieldInfo to add FieldTypeInfo.

        One question, though, LRH currently writes out the instance of the Analyzer (around line 371 of LRH), would it be better to just return the class name? Or do people actually need the value of Analyzer.toString()

        Also, do I need to worry about back-compatibility of the message? That is, if I add in the class name of the FieldType instance (i.e. solr.IntField, etc.) does that break the compatibility of the message?

        I will post a new patch shortly which has more access to the FieldType info.

        Show
        Grant Ingersoll added a comment - I am working on extending the LukeRequestHandler (LRH) and the LukeResponse to give more info about the FieldTypes. Right now, the LRH returns the name of the FieldType, but does not return the class name. Also, I would like to return back more structured access to the FieldType information by extracting it from the IndexInfo in the same way the FieldInfo does now. Currently, I am mirroring what is done for the FieldInfo to add FieldTypeInfo. One question, though, LRH currently writes out the instance of the Analyzer (around line 371 of LRH), would it be better to just return the class name? Or do people actually need the value of Analyzer.toString() Also, do I need to worry about back-compatibility of the message? That is, if I add in the class name of the FieldType instance (i.e. solr.IntField, etc.) does that break the compatibility of the message? I will post a new patch shortly which has more access to the FieldType info.
        Hide
        Grant Ingersoll added a comment -

        This patch builds on the last one to provide map backed access to FieldType metadata in a similar vein to the current FieldInfo. It adds the className of the FieldType into the LukeRequestHandler types NamedList.

        Show
        Grant Ingersoll added a comment - This patch builds on the last one to provide map backed access to FieldType metadata in a similar vein to the current FieldInfo. It adds the className of the FieldType into the LukeRequestHandler types NamedList.
        Hide
        Erik Hatcher added a comment -

        Patch applied, thanks!

        Luke keeps getting handier and handier.

        I also agree that the analyzer output is useless, especially with the className attribute now.

        Show
        Erik Hatcher added a comment - Patch applied, thanks! Luke keeps getting handier and handier. I also agree that the analyzer output is useless, especially with the className attribute now.
        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked "Resolved" and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15

        The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked "Resolved" and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15 The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development