Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3575

solr.xml should default to persist=true

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-BETA, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The default of false is kind of silly IMO.

        Issue Links

          Activity

          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml
          Perhaps every directory under the solr home could implicitly define a collection.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml Perhaps every directory under the solr home could implicitly define a collection.
          Hide
          janhoy Jan Høydahl added a comment -

          +1

          related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml Perhaps every directory under the solr home could implicitly define a collection.

          Yea, been thinking the same. How about a "my-core/collection.properties" file to set the various props? If file exists but is empty it could be a simple marker that this is a core and assume defaults for all settings. And how about adding SOLR_HOME/lib as shared lib folder by convention and SOLR_HOME/core/lib as core-specific lib folder? We might then not need solr.xml at all?

          Show
          janhoy Jan Høydahl added a comment - +1 related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml Perhaps every directory under the solr home could implicitly define a collection. Yea, been thinking the same. How about a "my-core/collection.properties" file to set the various props? If file exists but is empty it could be a simple marker that this is a core and assume defaults for all settings. And how about adding SOLR_HOME/lib as shared lib folder by convention and SOLR_HOME/core/lib as core-specific lib folder? We might then not need solr.xml at all?
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          We should create another issue for that (though it would be easier to do on a major release perhaps) - I'll commit this quick change in a bit to make sure we have at least this improvement.

          Show
          markrmiller@gmail.com Mark Miller added a comment - We should create another issue for that (though it would be easier to do on a major release perhaps) - I'll commit this quick change in a bit to make sure we have at least this improvement.
          Hide
          hossman Hoss Man added a comment -

          hoss20120711-manual-post-40alpha-change

          Show
          hossman Hoss Man added a comment - hoss20120711-manual-post-40alpha-change
          Hide
          mange Magnus Bergmark added a comment -

          > related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml
          > Perhaps every directory under the solr home could implicitly define a collection.

          Not a good idea. We unload cores to save memory on some machines, then load them on demand. This would make it much harder for us to accomplish.

          Also, what would happen if a core was unloaded?

          Show
          mange Magnus Bergmark added a comment - > related: it would be nice if the coming/going of cores didn't necessitate changing solr.xml > Perhaps every directory under the solr home could implicitly define a collection. Not a good idea. We unload cores to save memory on some machines, then load them on demand. This would make it much harder for us to accomplish. Also, what would happen if a core was unloaded?
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          We would still support loading and unloading.

          Also, what would happen if a core was unloaded?

          The simple properties file or whatever in each core folder would indicate the core was not 'loaded'. Or one of many other solutions.

          Show
          markrmiller@gmail.com Mark Miller added a comment - We would still support loading and unloading. Also, what would happen if a core was unloaded? The simple properties file or whatever in each core folder would indicate the core was not 'loaded'. Or one of many other solutions.

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development