Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1
    • Component/s: web gui
    • Labels:
      None

      Description

      As follow up on SOLR-3367, we should try to handle all "type" of Exceptions - the good ones as well as the bad ones:

      throw new RuntimeException( "error "+cause );
      {
      	time: "2012-05-16T13:26:10.722Z",
      	level: "SEVERE",
      	logger: "org.apache.solr.core.SolrCore",
      	message: "org.apache.solr.common.SolrException: Can not find: schema.not [/opt/solr-trunk/solr/example/solr/./conf/schema.not]
      		at org.apache.solr.handler.admin.ShowFileRequestHandler.showFromFileSystem(ShowFileRequestHandler.java:229)
      		at org.apache.solr.handler.admin.ShowFileRequestHandler.handleRequestBody(ShowFileRequestHandler.java:122)
      		..."
      }

      and

      throw new RuntimeException( "error message", cause );
      {
      	time: "2012-05-16T13:25:03.679Z",
      	level: "SEVERE",
      	logger: "org.apache.solr.handler.admin.LoggingHandler",
      	message: "error (with exception)",
      	trace: "java.lang.RuntimeException: test
      		at org.apache.solr.handler.admin.LoggingHandler.handleRequestBody(LoggingHandler.java:75)
      		at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:129)
      		..."
      }

      First Idea would be, to check for an existing trace-Index .. if the record has none, we expect the whole Output to be stored in message - so we split on the first Line-break, take the former part as new message and use the latter as trace.

      If that will not work (at least for specific cases) and you already know about .. please speak up

      1. SOLR-3560.patch
        0.8 kB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Stefan Matheis (steffkes) added a comment -

          Thought this would be more complicated .. but after having a quick look, this works.

          Show
          Stefan Matheis (steffkes) added a comment - Thought this would be more complicated .. but after having a quick look, this works.
          Hide
          Ryan McKinley added a comment -

          Interesting... essentially moving anything after a \n to the 'trace' section regardless of if it is a trace or not.

          Seems like an OK hack – though it may be better to put the whole string in the trace element:

          +              doc.trace = doc.message;
          +              doc.message = lines[0];
          

          ideally we should have a style that deals with very long strings OK... but this is a good improvement. +1

          Show
          Ryan McKinley added a comment - Interesting... essentially moving anything after a \n to the 'trace' section regardless of if it is a trace or not. Seems like an OK hack – though it may be better to put the whole string in the trace element: + doc.trace = doc.message; + doc.message = lines[0]; ideally we should have a style that deals with very long strings OK... but this is a good improvement. +1
          Hide
          Hoss Man added a comment -

          bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

          Show
          Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
          Hide
          Robert Muir added a comment -

          rmuir20120906-bulk-40-change

          Show
          Robert Muir added a comment - rmuir20120906-bulk-40-change
          Hide
          Robert Muir added a comment -

          moving all 4.0 issues not touched in a month to 4.1

          Show
          Robert Muir added a comment - moving all 4.0 issues not touched in a month to 4.1
          Hide
          Stefan Matheis (steffkes) added a comment -

          Committed revision 1389981. trunk
          Committed revision 1389982. branch_4x

          Show
          Stefan Matheis (steffkes) added a comment - Committed revision 1389981. trunk Committed revision 1389982. branch_4x
          Hide
          Stefan Matheis (steffkes) added a comment -

          Committed revision 1392825. lucene_solr_4_0

          Show
          Stefan Matheis (steffkes) added a comment - Committed revision 1392825. lucene_solr_4_0
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Stefan Matheis
          http://svn.apache.org/viewvc?view=revision&revision=1389982

          SOLR-3560: Handle different types of Exception Messages for Logging UI (merge r1389981)

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1389982 SOLR-3560 : Handle different types of Exception Messages for Logging UI (merge r1389981)

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Stefan Matheis (steffkes)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development