[SOLR-3492] Caching of ReversedWildcardFilterFactory in SolrQueryParser looks broken

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6, 4.0-ALPHA
• Fix Version/s: 4.1
• Component/s: search
• Assignee: Unassigned
• Reporter: Michael Ryan
• Created: 28/May/12 00:53
• Updated: 11/Aug/14 02:19
• Resolved: 11/Aug/14 02:19

Description

The caching of ReversedWildcardFilterFactory in SolrQueryParser looks broken.

Here's the current code:

ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
if (fac == null && leadingWildcards.containsKey(fac)) {
  return fac;
}

That doesn't quite make sense - fac will never be returned, as leadingWildcards will never contain a null key. I think this is probably what was intended:

ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
if (fac != null) {
  return fac;
}

Issue Links

• relates to: SOLR-2438 Case Insensitive Search for Wildcard Queries