Solr
  1. Solr
  2. SOLR-348

faceting, highlighting, mlt, should short circut when no matches

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.

      optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)

      http://www.nabble.com/Slow-response-tf4394686.html

      1. facet.patch
        0.9 kB
        Yonik Seeley

        Activity

        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked "Resolved" and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15

        The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked "Resolved" and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.3 as of today 2008-03-15 The Fix Version for all 29 issues found was set to 1.3, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: batch20070315hossman1
        Hide
        Yonik Seeley added a comment -

        committed faceting part, and closing.
        if a separate component has an issue with no docs matching, we can open a separate issue.

        Show
        Yonik Seeley added a comment - committed faceting part, and closing. if a separate component has an issue with no docs matching, we can open a separate issue.
        Hide
        Yonik Seeley added a comment -

        Here's a patch for the faceting part that should work.

        Show
        Yonik Seeley added a comment - Here's a patch for the faceting part that should work.
        Hide
        Yonik Seeley added a comment -

        For faceting, docset.size() should be compared to mincount.

        Show
        Yonik Seeley added a comment - For faceting, docset.size() should be compared to mincount.
        Hide
        Mike Klaas added a comment -

        Note that highlighting already has short circuiting for hl!=true, and does almost no work when the DocList is empty.

        Show
        Mike Klaas added a comment - Note that highlighting already has short circuiting for hl!=true, and does almost no work when the DocList is empty.

          People

          • Assignee:
            Unassigned
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development