Solr
  1. Solr
  2. SOLR-3489

Config file replication less error prone

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6.1, 4.0-ALPHA
    • Component/s: replication (java)
    • Labels:
      None

      Description

      If the listing of configuration files that should be replicated contains a space, the following file is not replicated.
      Example:

      <!-- The error in the configuration is the space before stopwords.txt.
           Because of that that file is not replicated -->
      <str name="confFiles">schema.xml,test.txt, stopwords.txt</str>
      

      It would be nice, if that space simply would be ignored.

      1. SOLR-3489_reproducing_config.tar.gz
        3 kB
        Jochen Just
      2. SOLR-3489.patch
        0.7 kB
        Jan Høydahl
      3. SOLR-3489.patch
        1.0 kB
        Jochen Just

        Activity

        Hide
        Uwe Schindler added a comment -

        Bulk close for 3.6.1

        Show
        Uwe Schindler added a comment - Bulk close for 3.6.1
        Hide
        Jan Høydahl added a comment -

        You were right Jochen - my bad. I simplified the patch a bit and committed to both trunk and branch.

        Show
        Jan Høydahl added a comment - You were right Jochen - my bad. I simplified the patch a bit and committed to both trunk and branch.
        Hide
        Jan Høydahl added a comment -

        New smaller patch, for trunk

        Show
        Jan Høydahl added a comment - New smaller patch, for trunk
        Hide
        Jochen Just added a comment -

        I am not quite sure, whether I have understood the last comment. As I was quite surprised, to read that my patch is identical to the trunk code, I checked that. But in my opinion, this is not the case and the described problem still exists in trunk.

        Show
        Jochen Just added a comment - I am not quite sure, whether I have understood the last comment. As I was quite surprised, to read that my patch is identical to the trunk code, I checked that. But in my opinion, this is not the case and the described problem still exists in trunk.
        Hide
        Jan Høydahl added a comment -

        Thanks for reporting. You patch (which is identical with the trunk code) is committed to branch 3_6

        Show
        Jan Høydahl added a comment - Thanks for reporting. You patch (which is identical with the trunk code) is committed to branch 3_6
        Hide
        Jochen Just added a comment -

        I will look into that, but not before next week i guess

        Show
        Jochen Just added a comment - I will look into that, but not before next week i guess
        Hide
        Jack Krupansky added a comment -

        It would be nice to add a similar protection against space before and after the colon for aliases. As well as a check for an empty name before and after the colon.

        Show
        Jack Krupansky added a comment - It would be nice to add a similar protection against space before and after the colon for aliases. As well as a check for an empty name before and after the colon.
        Hide
        Jochen Just added a comment -

        The patch is based on branch lucene_solr_36

        Show
        Jochen Just added a comment - The patch is based on branch lucene_solr_36
        Hide
        Jochen Just added a comment -

        The attached patch should solve that problem.

        Show
        Jochen Just added a comment - The attached patch should solve that problem.
        Hide
        Jochen Just added a comment - - edited

        Steps to reproduce:

        1. unpack SOLR-3489_reproducing_config.tar.gz into solr-example directory
        2. start master via java -Denable.master=true -Dsolr.solr.home=master -jar start.jar
        3. start slave via java -Denable.slave=true -Dsolr.solr.home=slave -Djetty.port=8984 -jar start.jar
        4. add document in master/singledoc.xml to master
        5. either replicate manually or wait 60 seconds

        Result:

        • test.txt will be replicated
        • stopwords.txt won't
        Show
        Jochen Just added a comment - - edited Steps to reproduce: unpack SOLR-3489_reproducing_config.tar.gz into solr-example directory start master via java -Denable.master=true -Dsolr.solr.home=master -jar start.jar start slave via java -Denable.slave=true -Dsolr.solr.home=slave -Djetty.port=8984 -jar start.jar add document in master/singledoc.xml to master either replicate manually or wait 60 seconds Result: test.txt will be replicated stopwords.txt won't

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jochen Just
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development