Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.6
-
Component/s: replication (java)
-
Labels:None
Description
If the listing of configuration files that should be replicated contains a space, the following file is not replicated.
Example:
<!-- The error in the configuration is the space before stopwords.txt.
Because of that that file is not replicated -->
<str name="confFiles">schema.xml,test.txt, stopwords.txt</str>
It would be nice, if that space simply would be ignored.
Activity
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
You were right Jochen - my bad. I simplified the patch a bit and committed to both trunk and branch.
Show
Jan Høydahl
added a comment - You were right Jochen - my bad. I simplified the patch a bit and committed to both trunk and branch.
| Attachment | SOLR-3489.patch [ 12530020 ] |
New smaller patch, for trunk
Show
Jan Høydahl
added a comment - New smaller patch, for trunk
| Fix Version/s | 4.0 [ 12314992 ] | |
| Fix Version/s | 3.6.1 [ 12320754 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
I am not quite sure, whether I have understood the last comment. As I was quite surprised, to read that my patch is identical to the trunk code, I checked that. But in my opinion, this is not the case and the described problem still exists in trunk.
Show
Jochen Just
added a comment - I am not quite sure, whether I have understood the last comment. As I was quite surprised, to read that my patch is identical to the trunk code, I checked that. But in my opinion, this is not the case and the described problem still exists in trunk.
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
Thanks for reporting. You patch (which is identical with the trunk code) is committed to branch 3_6
Show
Jan Høydahl
added a comment - Thanks for reporting. You patch (which is identical with the trunk code) is committed to branch 3_6
| Assignee | Jan Høydahl [ janhoy ] |
I will look into that, but not before next week i guess
Show
Jochen Just
added a comment - I will look into that, but not before next week i guess
| Attachment |
|
It would be nice to add a similar protection against space before and after the colon for aliases. As well as a check for an empty name before and after the colon.
Show
Jack Krupansky
added a comment - It would be nice to add a similar protection against space before and after the colon for aliases. As well as a check for an empty name before and after the colon.
| Attachment | SOLR-3489_reproducing_config.tar.gz [ 12529721 ] |
| Attachment | SOLR-3489_reproducing_config.tar.gz [ 12529719 ] |
| Attachment |
|
The patch is based on branch lucene_solr_36
Show
Jochen Just
added a comment - The patch is based on branch lucene_solr_36
| Attachment | SOLR-3489.patch [ 12529716 ] |
The attached patch should solve that problem.
Show
Jochen Just
added a comment - The attached patch should solve that problem.
| Attachment | SOLR-3489_reproducing_config.tar.gz [ 12529713 ] |
Steps to reproduce:
- unpack SOLR-3489_reproducing_config.tar.gz
into solr-example directory - start master via java -Denable.master=true -Dsolr.solr.home=master -jar start.jar
- start slave via java -Denable.slave=true -Dsolr.solr.home=slave -Djetty.port=8984 -jar start.jar
- add document in master/singledoc.xml to master
- either replicate manually or wait 60 seconds
Result:
- test.txt will be replicated
- stopwords.txt won't
Show
Jochen Just
added a comment - - edited Steps to reproduce:
unpack SOLR-3489_reproducing_config.tar.gz into solr-example directory
start master via java -Denable.master=true -Dsolr.solr.home=master -jar start.jar
start slave via java -Denable.slave=true -Dsolr.solr.home=slave -Djetty.port=8984 -jar start.jar
add document in master/singledoc.xml to master
either replicate manually or wait 60 seconds
Result:
test.txt will be replicated
stopwords.txt won't
| Field | Original Value | New Value |
|---|---|---|
| Description |
If the listing of configuration files that should be replicated contains a space, the following file is not replicated.
Example: {{ <!-- the error in the configuration is the space before stopwords.txt. Because of that that file is not replicated --> <str name="confFiles">schema.xml,test.txt, stopwords.txt</str> }} It would be nice, if that space simply would be ignored. |
If the listing of configuration files that should be replicated contains a space, the following file is not replicated.
Example: {code:xml} <!-- The error in the configuration is the space before stopwords.txt. Because of that that file is not replicated --> <str name="confFiles">schema.xml,test.txt, stopwords.txt</str> {code} It would be nice, if that space simply would be ignored. |
Bulk close for 3.6.1