Solr
  1. Solr
  2. SOLR-3470

Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

        Details

        1. Text File
          SOLR-3470.patch
          12 kB
          Dawid Weiss

          Activity

          Ascending order - Click to sort in descending order
          Stanislaw Osinski created issue -
          Stanislaw Osinski made changes -
          Field Original Value New Value
          Fix Version/s 4.0 [ 12314992 ]
          Hide
          Permalink
          Stanislaw Osinski added a comment -

          Fixed in trunk and 3.6.1 branch.

          Show
          Stanislaw Osinski added a comment - Fixed in trunk and 3.6.1 branch.
          Stanislaw Osinski made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Permalink
          Stanislaw Osinski added a comment -

          Unit tests pass fine, but Carrot2's internal class resolution code (context class loader) doesn't play well with how Solr loads contrib classes in webapp mode.

          A brute-force fix would be to do the class loading the Solr way in the clustering component and pass class objects instead of strings to Carrot2.

          Show
          Stanislaw Osinski added a comment - Unit tests pass fine, but Carrot2's internal class resolution code (context class loader) doesn't play well with how Solr loads contrib classes in webapp mode. A brute-force fix would be to do the class loading the Solr way in the clustering component and pass class objects instead of strings to Carrot2.
          Stanislaw Osinski made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Dawid Weiss made changes -
          Assignee Stanislaw Osinski [ stanislaw.osinski ] Dawid Weiss [ dweiss ]
          Hide
          Permalink
          Dawid Weiss added a comment -

          Here's my take at solving this. I temporarily substitute the context class loader to be the one from solr's resource loader (core).

          This works (or seems to work) just fine. I don't particularly like it but I also don't want to mess with Solr's resource loaders if we don't have to.

          I also piggyback a few cleanups.

          Show
          Dawid Weiss added a comment - Here's my take at solving this. I temporarily substitute the context class loader to be the one from solr's resource loader (core). This works (or seems to work) just fine. I don't particularly like it but I also don't want to mess with Solr's resource loaders if we don't have to. I also piggyback a few cleanups.
          Dawid Weiss made changes -
          Attachment SOLR-3470.patch [ 12528397 ]
          Hide
          Permalink
          Dawid Weiss added a comment -

          Review and let me know what you think.

          Show
          Dawid Weiss added a comment - Review and let me know what you think.
          Dawid Weiss made changes -
          Assignee Dawid Weiss [ dweiss ] Stanislaw Osinski [ stanislaw.osinski ]
          Hide
          Permalink
          Stanislaw Osinski added a comment -

          Not pretty indeed, but still better than hardcoding Carrot2 attribute names. I'll commit this in a moment.

          Show
          Stanislaw Osinski added a comment - Not pretty indeed, but still better than hardcoding Carrot2 attribute names. I'll commit this in a moment.
          Hide
          Permalink
          Stanislaw Osinski added a comment -

          Dawid's patch committed to trunk and 3.6 branch.

          Show
          Stanislaw Osinski added a comment - Dawid's patch committed to trunk and 3.6 branch.
          Stanislaw Osinski made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Permalink
          Uwe Schindler added a comment -

          Bulk close for 3.6.1

          Show
          Uwe Schindler added a comment - Bulk close for 3.6.1
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Stanislaw Osinski
              Reporter:
              Stanislaw Osinski
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development