Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3470

Custom Carrot2 tokenizer and stemmer factories overwritten by defaults

        Details

        1. Text File
          SOLR-3470.patch
          12 kB
          Dawid Weiss

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          stanislaw.osinski Stanislaw Osinski added a comment -

          Fixed in trunk and 3.6.1 branch.

          Show
          stanislaw.osinski Stanislaw Osinski added a comment - Fixed in trunk and 3.6.1 branch.
          Hide
          Permalink
          stanislaw.osinski Stanislaw Osinski added a comment -

          Unit tests pass fine, but Carrot2's internal class resolution code (context class loader) doesn't play well with how Solr loads contrib classes in webapp mode.

          A brute-force fix would be to do the class loading the Solr way in the clustering component and pass class objects instead of strings to Carrot2.

          Show
          stanislaw.osinski Stanislaw Osinski added a comment - Unit tests pass fine, but Carrot2's internal class resolution code (context class loader) doesn't play well with how Solr loads contrib classes in webapp mode. A brute-force fix would be to do the class loading the Solr way in the clustering component and pass class objects instead of strings to Carrot2.
          Hide
          Permalink
          dweiss Dawid Weiss added a comment -

          Here's my take at solving this. I temporarily substitute the context class loader to be the one from solr's resource loader (core).

          This works (or seems to work) just fine. I don't particularly like it but I also don't want to mess with Solr's resource loaders if we don't have to.

          I also piggyback a few cleanups.

          Show
          dweiss Dawid Weiss added a comment - Here's my take at solving this. I temporarily substitute the context class loader to be the one from solr's resource loader (core). This works (or seems to work) just fine. I don't particularly like it but I also don't want to mess with Solr's resource loaders if we don't have to. I also piggyback a few cleanups.
          Hide
          Permalink
          dweiss Dawid Weiss added a comment -

          Review and let me know what you think.

          Show
          dweiss Dawid Weiss added a comment - Review and let me know what you think.
          Hide
          Permalink
          stanislaw.osinski Stanislaw Osinski added a comment -

          Not pretty indeed, but still better than hardcoding Carrot2 attribute names. I'll commit this in a moment.

          Show
          stanislaw.osinski Stanislaw Osinski added a comment - Not pretty indeed, but still better than hardcoding Carrot2 attribute names. I'll commit this in a moment.
          Hide
          Permalink
          stanislaw.osinski Stanislaw Osinski added a comment -

          Dawid's patch committed to trunk and 3.6 branch.

          Show
          stanislaw.osinski Stanislaw Osinski added a comment - Dawid's patch committed to trunk and 3.6 branch.
          Hide
          Permalink
          thetaphi Uwe Schindler added a comment -

          Bulk close for 3.6.1

          Show
          thetaphi Uwe Schindler added a comment - Bulk close for 3.6.1

            People

            • Assignee:
              stanislaw.osinski Stanislaw Osinski
              Reporter:
              stanislaw.osinski Stanislaw Osinski
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development