Solr
  1. Solr
  2. SOLR-3469

recovery can incorrectly succeed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Hypothetical scenario:

      • node comes up and needs to recover
      • node starts buffering updates and replicating index
      • node receives and buffers 1000 updates and dies before replication finishes
      • node comes up, replays tlog
      • peersync checks last 100 updates, they match, and node goes into "active" state (without having ever finished the index replication)
      1. SOLR-3469.patch
        17 kB
        Yonik Seeley

        Activity

        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Yonik Seeley made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.0 [ 12314992 ]
        Resolution Fixed [ 1 ]
        Yonik Seeley made changes -
        Field Original Value New Value
        Attachment SOLR-3469.patch [ 12528505 ]
        Hide
        Yonik Seeley added a comment -

        Here's a draft patch that doesn't quite work yet. The direction I'm going is to add flags to the tlog entries when adding buffered entries. On startup, we look at (and keep track of) the latest entry. If the flag is set, then we don't try peersync when we are recovering.

        Show
        Yonik Seeley added a comment - Here's a draft patch that doesn't quite work yet. The direction I'm going is to add flags to the tlog entries when adding buffered entries. On startup, we look at (and keep track of) the latest entry. If the flag is set, then we don't try peersync when we are recovering.
        Yonik Seeley created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development