Solr
  1. Solr
  2. SOLR-3453

edismax lowercaseOperators=false broken by SOLR-3026

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 4.0-ALPHA, Trunk
    • Component/s: search
    • Labels:
      None

      Description

      The edismax lowercaseOperators=false option seems to have been broken by SOLR-3026. "foo and bar" and "foo or bar" are treated as "foo AND bar" and "foo OR bar", respectively, even when lowercaseOperators=false.

      Fix is rather simple, I think (though I haven't tested this). Current code:

              if (i>0 && i+1<clauses.size()) {
                if ("AND".equalsIgnoreCase(s)) {
                  s="AND";
                } else if ("OR".equalsIgnoreCase(s)) {
                  s="OR";
                }
              }

      Proposed code:

              if (lowercaseOperators) {
                if (i>0 && i+1<clauses.size()) {
                  if ("AND".equalsIgnoreCase(s)) {
                    s="AND";
                  } else if ("OR".equalsIgnoreCase(s)) {
                    s="OR";
                  }
                }
              }

      Also interesting is the treatment of "Or" and "oR", but I'll leave that as an exercise to the reader.

      1. SOLR-3026.patch
        2 kB
        Tomás Fernández Löbbe
      2. SOLR-3026.patch
        2 kB
        Tomás Fernández Löbbe
      3. SOLR-3453
        2 kB
        Erick Erickson

        Issue Links

          Activity

          Michael Ryan created issue -
          Michael Ryan made changes -
          Field Original Value New Value
          Link This issue relates to SOLR-3026 [ SOLR-3026 ]
          Tomás Fernández Löbbe made changes -
          Attachment SOLR-3026.patch [ 12527708 ]
          Tomás Fernández Löbbe made changes -
          Attachment SOLR-3026.patch [ 12527718 ]
          Erick Erickson made changes -
          Attachment SOLR-3453 [ 12532732 ]
          Erick Erickson made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 5.0 [ 12321664 ]
          Resolution Fixed [ 1 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Michael Ryan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development