Solr
  1. Solr
  2. SOLR-3441

Make ElisionFilterFactory MultiTermAware

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 4.0, 6.0
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      The ElisionFilterFactory (which removes l' from l'avion) is not MultiTermAware - which includes release 3.6. I wanted to use a wildcard such as: (l'aub*).

      Seems simple enough to address. I'll attach a patch.

      1. SOLR-3441.patch
        5 kB
        Hoss Man
      2. SOLR-3441.patch
        10 kB
        Jack Krupansky

        Activity

        Hide
        Jack Krupansky added a comment -

        Preliminary patch.

        Show
        Jack Krupansky added a comment - Preliminary patch.
        Hide
        Jack Krupansky added a comment -

        It would be nice if this could be committed.

        Show
        Jack Krupansky added a comment - It would be nice if this could be committed.
        Hide
        Erik Hatcher added a comment -

        adjusting this for 4.0 visibility

        Show
        Erik Hatcher added a comment - adjusting this for 4.0 visibility
        Hide
        Hoss Man added a comment -

        I don't really know if it makes sense logically to make ElisionFilterFactory MultiTermAware, but i went ahead and updated the patch for trunk, and simplified the test analyzer so we don't have duplicate copies of the stopwords and articles (stopwords weren't used in the test, and the factory already defaults to french articles)

        Show
        Hoss Man added a comment - I don't really know if it makes sense logically to make ElisionFilterFactory MultiTermAware, but i went ahead and updated the patch for trunk, and simplified the test analyzer so we don't have duplicate copies of the stopwords and articles (stopwords weren't used in the test, and the factory already defaults to french articles)
        Hide
        Hoss Man added a comment -

        Thanks Jack!

        Committed revision 1379275. trunk
        Committed revision 1379276. 4x

        Show
        Hoss Man added a comment - Thanks Jack! Committed revision 1379275. trunk Committed revision 1379276. 4x
        Hide
        Jack Krupansky added a comment -

        Thanks for the commit!

        Show
        Jack Krupansky added a comment - Thanks for the commit!
        Hide
        Erick Erickson added a comment -

        Thanks Hoss! Somehow I managed to lose this one.

        Show
        Erick Erickson added a comment - Thanks Hoss! Somehow I managed to lose this one.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Jack Krupansky
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development