Solr
  1. Solr
  2. SOLR-3422

Refactor DIH - configuration data

    Details

      Description

      In my spare time, I would like to try and make DIH into something that is a Joy to Maintain.

      Here's a tiny first step: put the configuration data into immutable classes, moving state data elsewhere.

      1. SOLR-3422.patch
        121 kB
        James Dyer
      2. SOLR-3422.patch
        149 kB
        James Dyer

        Activity

        Hide
        James Dyer added a comment -

        This is a big patch file, but it mostly is just moving things around.

        All DIH tests pass, and I plan on committing this shortly.

        Show
        James Dyer added a comment - This is a big patch file, but it mostly is just moving things around. All DIH tests pass, and I plan on committing this shortly.
        Hide
        Mark Miller added a comment -

        In my spare time, I would like to try and make DIH into something that is a Joy to Maintain

        +1 - nice.

        Show
        Mark Miller added a comment - In my spare time, I would like to try and make DIH into something that is a Joy to Maintain +1 - nice.
        Hide
        Mikhail Khludnev added a comment -

        All DIH tests pass,

        I'm sorry for hijacking, but I want to remind that important test cases from SOLR-3360 should be committed.

        Show
        Mikhail Khludnev added a comment - All DIH tests pass, I'm sorry for hijacking, but I want to remind that important test cases from SOLR-3360 should be committed.
        Hide
        James Dyer added a comment -

        updated patch.

        Show
        James Dyer added a comment - updated patch.
        Hide
        James Dyer added a comment -

        Committed to Trunk, r1332292.

        Show
        James Dyer added a comment - Committed to Trunk, r1332292.

          People

          • Assignee:
            James Dyer
            Reporter:
            James Dyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development