Solr
  1. Solr
  2. SOLR-3402

Parse Version outside of Analysis Factories

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Currently the Lucene Version value is put into the Map that is passed to the init method of Analysis factories. During the initialization, the value is parsed and validated. In situations where the Core wide value is used, it is converted to a String only for it to be parsed again. I think we can improve this, reduce the amount of parsing, and provide a cleaner separation of concerns.

      Instead the value should be parsed externally and then passed into the Factory. The Factory would be responsible for checking that it was given a Version value. Any additional validation such as general guidelines about Versions to use, would then fall on code that passed in the Version to the Factory (namely, FieldPluginLoader).

      1. SOLR-3402.patch
        72 kB
        Chris Male
      2. SOLR-3402.patch
        71 kB
        Chris Male
      3. SOLR-3402.patch
        67 kB
        Chris Male

        Activity

        Hide
        Chris Male added a comment -

        Fixed in trunk.

        Show
        Chris Male added a comment - Fixed in trunk.
        Hide
        Chris Male added a comment -

        Finished moving the Version guideline stuff around. Ready for commit in a few days.

        Show
        Chris Male added a comment - Finished moving the Version guideline stuff around. Ready for commit in a few days.
        Hide
        Chris Male added a comment -

        Patch moves lenient parsing of Versions into Version. Still need to move some Version guidelines out of BaseTokenStreamFactory

        Show
        Chris Male added a comment - Patch moves lenient parsing of Versions into Version. Still need to move some Version guidelines out of BaseTokenStreamFactory
        Hide
        Chris Male added a comment -

        Patch doing what is described above.

        Some nocommits in BaseTokeTestCase to iron out still.

        Show
        Chris Male added a comment - Patch doing what is described above. Some nocommits in BaseTokeTestCase to iron out still.

          People

          • Assignee:
            Chris Male
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development