Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3402

Parse Version outside of Analysis Factories

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Currently the Lucene Version value is put into the Map that is passed to the init method of Analysis factories. During the initialization, the value is parsed and validated. In situations where the Core wide value is used, it is converted to a String only for it to be parsed again. I think we can improve this, reduce the amount of parsing, and provide a cleaner separation of concerns.

      Instead the value should be parsed externally and then passed into the Factory. The Factory would be responsible for checking that it was given a Version value. Any additional validation such as general guidelines about Versions to use, would then fall on code that passed in the Version to the Factory (namely, FieldPluginLoader).

        Attachments

        1. SOLR-3402.patch
          72 kB
          Chris Male
        2. SOLR-3402.patch
          71 kB
          Chris Male
        3. SOLR-3402.patch
          67 kB
          Chris Male

          Activity

            People

            • Assignee:
              cmale Chris Male
              Reporter:
              cmale Chris Male
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: