Solr
  1. Solr
  2. SOLR-3371

Admin UI breaks with a core named 'logging' or 'threads'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      If you make a core with the name "logging" or "threads" the UI gets confused with the logging or threads page.

      It seems like the ~threads and ~logging should be enough to distinguish

      1. SOLR-3371.patch
        4 kB
        Stefan Matheis (steffkes)
      2. SOLR-3371.patch
        4 kB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Stefan Matheis (steffkes) added a comment -

          It seems like the ~threads and ~logging should be enough to distinguish

          Hum, yes .. that was the idea :/ Attached Patch changes Handling for "global" Actions (prefixed with ~)

          Show
          Stefan Matheis (steffkes) added a comment - It seems like the ~threads and ~logging should be enough to distinguish Hum, yes .. that was the idea :/ Attached Patch changes Handling for "global" Actions (prefixed with ~)
          Hide
          Ryan McKinley added a comment -

          This works for everything except the "cores" page – I tried following the pattern and chaning:

          ===================================================================
          --- web/js/scripts/cores.js     (revision 1327715)
          +++ web/js/scripts/cores.js     (working copy)
          @@ -104,7 +104,7 @@
           // #/~cores
           sammy.get
           (
          -  /^#\/~(cores)$/,
          +  /^#\/(~cores)$/,
             function( context )
             {
               delete app.cores_template;
          

          but that fails when I click on it. (i links to /#/~cores/core0)

          Show
          Ryan McKinley added a comment - This works for everything except the "cores" page – I tried following the pattern and chaning: =================================================================== --- web/js/scripts/cores.js (revision 1327715) +++ web/js/scripts/cores.js (working copy) @@ -104,7 +104,7 @@ // #/~cores sammy.get ( - /^#\/~(cores)$/, + /^#\/(~cores)$/, function( context ) { delete app.cores_template; but that fails when I click on it. (i links to /#/~cores/core0)
          Hide
          Stefan Matheis (steffkes) added a comment -

          Will see that we get SOLR-3174 committed, otherwise i have to handle multiple changes on the same file. But i've already prepared a patch for that ... including the core-admin :>

          Show
          Stefan Matheis (steffkes) added a comment - Will see that we get SOLR-3174 committed, otherwise i have to handle multiple changes on the same file. But i've already prepared a patch for that ... including the core-admin :>
          Hide
          Ryan McKinley added a comment -

          got it. +1 when you are ready

          I'm also +1 to commit SOLR-3174 as a work in progress BTW – as long as it does not break anything obvious and moves things forward. Getting feedback and iterating is much easier on /trunk then having people apply patches etc.

          Show
          Ryan McKinley added a comment - got it. +1 when you are ready I'm also +1 to commit SOLR-3174 as a work in progress BTW – as long as it does not break anything obvious and moves things forward. Getting feedback and iterating is much easier on /trunk then having people apply patches etc.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Updated Patch (Line-Numbers in cloud.js changed).

          Ryan, Core-Admin works for me :? Does it still not work for you? And if so, did you get an error message or just no reaction while browsing Core-Admin? And beside this, which OS/Browser is it?

          Show
          Stefan Matheis (steffkes) added a comment - Updated Patch (Line-Numbers in cloud.js changed). Ryan, Core-Admin works for me :? Does it still not work for you? And if so, did you get an error message or just no reaction while browsing Core-Admin? And beside this, which OS/Browser is it?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Ryan, it's still working for me, like i'd expect it to do .. did you get a chance to try it again?

          Show
          Stefan Matheis (steffkes) added a comment - Ryan, it's still working for me, like i'd expect it to do .. did you get a chance to try it again?
          Hide
          Stefan Matheis (steffkes) added a comment -

          Looks like this worked :> Changes were committed in r1335213

          Show
          Stefan Matheis (steffkes) added a comment - Looks like this worked :> Changes were committed in r1335213

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development