Solr
  1. Solr
  2. SOLR-3363

Replace RuntimeExceptions in Analysis Factories

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      Currently there is no consistent use of Exceptions in Analysis factories. Some throw RuntimeExceptions, some throw SolrExceptions, some include information about an Exception they are wrapping, others just wrap, throw and move on.

      I think a better way would be to have an InitializationException that the Factories can throw in init() or inform(ResourceLoader). We can then tailor the Exception to meet the needs of the Factories, and it gives us a bit of future proofing if/when we improve the property validation done in the factories.

        Activity

        Hide
        Chris Male added a comment -

        Patch.

        Show
        Chris Male added a comment - Patch.
        Hide
        Chris Male added a comment -

        Resolved in trunk.

        Show
        Chris Male added a comment - Resolved in trunk.

          People

          • Assignee:
            Chris Male
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development