Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3363

Replace RuntimeExceptions in Analysis Factories

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-ALPHA
    • Schema and Analysis
    • None

    Description

      Currently there is no consistent use of Exceptions in Analysis factories. Some throw RuntimeExceptions, some throw SolrExceptions, some include information about an Exception they are wrapping, others just wrap, throw and move on.

      I think a better way would be to have an InitializationException that the Factories can throw in init() or inform(ResourceLoader). We can then tailor the Exception to meet the needs of the Factories, and it gives us a bit of future proofing if/when we improve the property validation done in the factories.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cmale Chris Male
            cmale Chris Male
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment