Solr
  1. Solr
  2. SOLR-3355

Add shard name to SolrCore statistics

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-BETA, 5.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The JMX stats of the core do not expose the shard name that it is hosting, which could be of use.

      1. SOLR-3355.patch
        0.8 kB
        Michael Garski
      2. SOLR-3355.patch
        4 kB
        Mark Miller

        Activity

        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hoss Man made changes -
        Fix Version/s 4.0 [ 12322455 ]
        Fix Version/s 4.0-ALPHA [ 12314992 ]
        Hide
        Hoss Man added a comment -

        hoss20120711-manual-post-40alpha-change

        Show
        Hoss Man added a comment - hoss20120711-manual-post-40alpha-change
        Hide
        Mark Miller added a comment -

        Fixed.

        Show
        Mark Miller added a comment - Fixed.
        Mark Miller made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        markrmiller committed 1359468 (4 files)
        markrmiller committed 1359467 (1 file)
        Reviews: none

        SOLR-3355: fix bug around null shard / collection in statistics

        Hide
        Mark Miller added a comment -

        FYI - the 'blowup' is simply a warning in the logs - and probably loss of some info in jmx that would normally be loaded after (if there was any left).

        Show
        Mark Miller added a comment - FYI - the 'blowup' is simply a warning in the logs - and probably loss of some info in jmx that would normally be loaded after (if there was any left).
        Mark Miller made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Mark Miller added a comment -

        This can cause a small issue - in cloud mode, when you want to auto shard, jmx 'stuff' tries to access shard and blows up because it is null in getStats. I'll make a small change so that when shard is null it shows up as auto in getStats.

        Show
        Mark Miller added a comment - This can cause a small issue - in cloud mode, when you want to auto shard, jmx 'stuff' tries to access shard and blows up because it is null in getStats. I'll make a small change so that when shard is null it shows up as auto in getStats.
        Mark Miller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mark Miller added a comment -

        Thanks Michael!

        Show
        Mark Miller added a comment - Thanks Michael!
        Mark Miller made changes -
        Attachment SOLR-3355.patch [ 12535217 ]
        Mark Miller made changes -
        Fix Version/s 5.0 [ 12321664 ]
        Hide
        Mark Miller added a comment -

        I've added collection as well and wrote a couple tests for this - I'll commit shortly.

        Show
        Mark Miller added a comment - I've added collection as well and wrote a couple tests for this - I'll commit shortly.
        Mark Miller made changes -
        Fix Version/s 4.0 [ 12314992 ]
        Affects Version/s 4.0 [ 12314992 ]
        Mark Miller made changes -
        Assignee Mark Miller [ markrmiller@gmail.com ]
        Michael Garski made changes -
        Field Original Value New Value
        Attachment SOLR-3355.patch [ 12522490 ]
        Hide
        Michael Garski added a comment -

        I could not find any tests that cover the SolrCore.getStatistics call, so this patch only adds the core name to the stats if possible.

        Show
        Michael Garski added a comment - I could not find any tests that cover the SolrCore.getStatistics call, so this patch only adds the core name to the stats if possible.
        Michael Garski created issue -

          People

          • Assignee:
            Mark Miller
            Reporter:
            Michael Garski
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development