Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3355

Add shard name to SolrCore statistics

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Trivial
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.0-BETA, 6.0
        • Component/s: SolrCloud
        • Labels:
          None

          Description

          The JMX stats of the core do not expose the shard name that it is hosting, which could be of use.

          1. Text File
            SOLR-3355.patch
            4 kB
            Mark Miller
          2. Text File
            SOLR-3355.patch
            0.8 kB
            Michael Garski

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mgarski Michael Garski added a comment -

            I could not find any tests that cover the SolrCore.getStatistics call, so this patch only adds the core name to the stats if possible.

            Show
            mgarski Michael Garski added a comment - I could not find any tests that cover the SolrCore.getStatistics call, so this patch only adds the core name to the stats if possible.
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            I've added collection as well and wrote a couple tests for this - I'll commit shortly.

            Show
            markrmiller@gmail.com Mark Miller added a comment - I've added collection as well and wrote a couple tests for this - I'll commit shortly.
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            Thanks Michael!

            Show
            markrmiller@gmail.com Mark Miller added a comment - Thanks Michael!
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            This can cause a small issue - in cloud mode, when you want to auto shard, jmx 'stuff' tries to access shard and blows up because it is null in getStats. I'll make a small change so that when shard is null it shows up as auto in getStats.

            Show
            markrmiller@gmail.com Mark Miller added a comment - This can cause a small issue - in cloud mode, when you want to auto shard, jmx 'stuff' tries to access shard and blows up because it is null in getStats. I'll make a small change so that when shard is null it shows up as auto in getStats.
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            FYI - the 'blowup' is simply a warning in the logs - and probably loss of some info in jmx that would normally be loaded after (if there was any left).

            Show
            markrmiller@gmail.com Mark Miller added a comment - FYI - the 'blowup' is simply a warning in the logs - and probably loss of some info in jmx that would normally be loaded after (if there was any left).
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            Fixed.

            Show
            markrmiller@gmail.com Mark Miller added a comment - Fixed.
            Hide
            Permalink
            hossman Hoss Man added a comment -

            hoss20120711-manual-post-40alpha-change

            Show
            hossman Hoss Man added a comment - hoss20120711-manual-post-40alpha-change

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                mgarski Michael Garski
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development